Skip to content

Commit 837d7ca

Browse files
authored
chore(clerk-js): Remove non-actionable error from Session poller (#5494)
1 parent 67d34eb commit 837d7ca

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

.changeset/fresh-numbers-sink.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@clerk/clerk-js': patch
3+
---
4+
5+
Remove non-actionable error from Session poller.

packages/clerk-js/src/core/auth/AuthCookieService.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { createCookieHandler } from '@clerk/shared/cookie';
22
import { setDevBrowserJWTInURL } from '@clerk/shared/devBrowser';
3-
import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError } from '@clerk/shared/error';
3+
import { is4xxError, isClerkAPIResponseError, isClerkRuntimeError, isNetworkError } from '@clerk/shared/error';
44
import { noop } from '@clerk/shared/utils';
55
import type { Clerk, InstanceType } from '@clerk/types';
66

7-
import { clerkCoreErrorTokenRefreshFailed, clerkMissingDevBrowserJwt } from '../errors';
7+
import { clerkMissingDevBrowserJwt } from '../errors';
88
import { eventBus, events } from '../events';
99
import type { FapiClient } from '../fapiClient';
1010
import type { ClientUatCookieHandler } from './cookies/clientUat';
@@ -181,18 +181,21 @@ export class AuthCookieService {
181181
}
182182

183183
private handleGetTokenError(e: any) {
184-
//throw if not a clerk api error (aka fapi error) and not a network error
185-
if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e)) {
186-
clerkCoreErrorTokenRefreshFailed(e.message || e);
184+
//early return if not a clerk api error (aka fapi error) and not a network error
185+
if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e) && !isNetworkError(e)) {
186+
return;
187187
}
188188

189189
//sign user out if a 4XX error
190190
if (is4xxError(e)) {
191191
void this.clerk.handleUnauthenticated().catch(noop);
192192
return;
193193
}
194+
195+
// --------
194196
// Treat any other error as a noop
195197
// TODO(debug-logs): Once debug logs is available log this error.
198+
// --------
196199
}
197200

198201
/**

packages/clerk-js/src/core/errors.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ export function clerkMissingFapiClientInResources(): never {
4646
throw new Error(`${errorPrefix} Missing FAPI client in resources.`);
4747
}
4848

49-
export function clerkCoreErrorTokenRefreshFailed(message: string): never {
50-
throw new Error(`${errorPrefix} Token refresh failed (error='${message}')`);
51-
}
52-
5349
export function clerkOAuthCallbackDidNotCompleteSignInSignUp(type: 'sign in' | 'sign up'): never {
5450
throw new Error(
5551
`${errorPrefix} Something went wrong initializing Clerk during the ${type} flow. Please contact support.`,

0 commit comments

Comments
 (0)