Skip to content

Commit 8423e36

Browse files
committed
Simplify EnterpriseConnectionTestRun resource
1 parent ff186e5 commit 8423e36

2 files changed

Lines changed: 4 additions & 14 deletions

File tree

packages/clerk-js/src/core/resources/EnterpriseConnectionTestRun.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,9 @@ import type {
1414

1515
import { unixEpochToDate } from '../../utils/date';
1616
import { clerkUnsupportedReloadMethod } from '../errors';
17-
import { BaseResource } from './Base';
1817

19-
export class EnterpriseConnectionTestRun extends BaseResource implements EnterpriseConnectionTestRunResource {
18+
export class EnterpriseConnectionTestRun implements EnterpriseConnectionTestRunResource {
2019
pathRoot = '/me';
21-
private enterpriseConnectionId = '';
2220

2321
id!: string;
2422
status!: string;
@@ -29,21 +27,15 @@ export class EnterpriseConnectionTestRun extends BaseResource implements Enterpr
2927
oauth: EnterpriseConnectionTestRunOauthPayloadResource | null = null;
3028
createdAt: Date | null = null;
3129

32-
constructor(data: EnterpriseConnectionTestRunJSON, enterpriseConnectionId: string) {
33-
super();
34-
this.enterpriseConnectionId = enterpriseConnectionId;
30+
constructor(data: EnterpriseConnectionTestRunJSON) {
3531
this.fromJSON(data);
3632
}
3733

38-
protected path(): string {
39-
return `${this.pathRoot}/enterprise_connections/${this.enterpriseConnectionId}/test_runs/${this.id}`;
40-
}
41-
4234
reload(_?: ClerkResourceReloadParams): Promise<this> {
4335
clerkUnsupportedReloadMethod('EnterpriseConnectionTestRun');
4436
}
4537

46-
protected fromJSON(data: EnterpriseConnectionTestRunJSON | null): this {
38+
private fromJSON(data: EnterpriseConnectionTestRunJSON | null): this {
4739
if (!data) {
4840
return this;
4941
}

packages/clerk-js/src/core/resources/User.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -403,9 +403,7 @@ export class User extends BaseResource implements UserResource {
403403

404404
return {
405405
total_count: payload?.total_count ?? 0,
406-
data: (payload?.data ?? []).map(
407-
(row: EnterpriseConnectionTestRunJSON) => new EnterpriseConnectionTestRun(row, enterpriseConnectionId),
408-
),
406+
data: (payload?.data ?? []).map((row: EnterpriseConnectionTestRunJSON) => new EnterpriseConnectionTestRun(row)),
409407
};
410408
};
411409

0 commit comments

Comments
 (0)