chore: revert e2e

Author: wobsoriano

integration/testUtils/machineAuthHelpers.ts

@@ -177,10 +177,6 @@ export type MachineAuthTestAdapter = {
     callbackPath: string;
     addRoutes: RouteBuilder;
   };
-  rateLimit?: {
-    path: string;
-    addRoutes: RouteBuilder;
-  };
 };
 
 const createApiKeysEnv = (): EnvironmentConfig => appConfigs.envs.withAPIKeys.clone();
@@ -449,95 +445,3 @@ export const registerOAuthAuthTests = (adapter: MachineAuthTestAdapter): void =>
     }
   });
 };
-
-export const registerRateLimitTests = (adapter: MachineAuthTestAdapter): void => {
-  if (!adapter.rateLimit) {
-    return;
-  }
-
-  test.describe('Machine token rate limiting', () => {
-    test.describe.configure({ mode: 'serial' });
-    let app: Application;
-    let fakeUser: FakeUser;
-    let fakeBapiUser: User;
-    let fakeAPIKey: FakeAPIKey;
-
-    test.beforeAll(async () => {
-      test.setTimeout(120_000);
-
-      app = await buildApp(adapter, adapter.rateLimit!.addRoutes);
-      await app.setup();
-      await app.withEnv(createApiKeysEnv());
-      await app.dev();
-
-      const u = createTestUtils({ app });
-      fakeUser = u.services.users.createFakeUser();
-      fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
-      fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
-    });
-
-    test.afterAll(async () => {
-      await fakeAPIKey?.revoke();
-      await fakeUser?.deleteIfExists();
-      await app?.teardown();
-    });
-
-    test('rate-limits opaque machine tokens after burst exhaustion', async ({ request }) => {
-      const url = new URL(adapter.rateLimit!.path, app.serverUrl).toString();
-      // Use a dedicated test IP so this test's bucket is isolated from others
-      const testIp = '203.0.113.42';
-
-      for (let i = 0; i < 20; i++) {
-        await request.get(url, {
-          headers: {
-            Authorization: `Bearer ${fakeAPIKey.secret}`,
-            'x-forwarded-for': testIp,
-          },
-        });
-      }
-
-      const res = await request.get(url, {
-        headers: {
-          Authorization: `Bearer ${fakeAPIKey.secret}`,
-          'x-forwarded-for': testIp,
-        },
-      });
-      expect(res.status()).toBe(401);
-      const body = await res.json();
-      expect(body.reason).toBe('machine-token-rate-limit');
-    });
-
-    test('tracks different source IPs independently', async ({ request }) => {
-      const url = new URL(adapter.rateLimit!.path, app.serverUrl).toString();
-      const ipA = '203.0.113.1';
-      const ipB = '203.0.113.2';
-
-      for (let i = 0; i < 20; i++) {
-        await request.get(url, {
-          headers: {
-            Authorization: `Bearer ${fakeAPIKey.secret}`,
-            'x-forwarded-for': ipA,
-          },
-        });
-      }
-
-      const resA = await request.get(url, {
-        headers: {
-          Authorization: `Bearer ${fakeAPIKey.secret}`,
-          'x-forwarded-for': ipA,
-        },
-      });
-      expect(resA.status()).toBe(401);
-      const bodyA = await resA.json();
-      expect(bodyA.reason).toBe('machine-token-rate-limit');
-
-      const resB = await request.get(url, {
-        headers: {
-          Authorization: `Bearer ${fakeAPIKey.secret}`,
-          'x-forwarded-for': ipB,
-        },
-      });
-      expect(resB.status()).toBe(200);
-    });
-  });
-};

integration/tests/next-machine.test.ts

@@ -2,12 +2,7 @@ import { test } from '@playwright/test';
 
 import { appConfigs } from '../presets';
 import type { MachineAuthTestAdapter } from '../testUtils/machineAuthHelpers';
-import {
-  registerApiKeyAuthTests,
-  registerM2MAuthTests,
-  registerOAuthAuthTests,
-  registerRateLimitTests,
-} from '../testUtils/machineAuthHelpers';
+import { registerApiKeyAuthTests, registerM2MAuthTests, registerOAuthAuthTests } from '../testUtils/machineAuthHelpers';
 
 const adapter: MachineAuthTestAdapter = {
   baseConfig: appConfigs.next.appRouter,
@@ -93,32 +88,10 @@ const adapter: MachineAuthTestAdapter = {
           `,
         ),
   },
-  rateLimit: {
-    path: '/api/rate-limit-test',
-    addRoutes: config =>
-      config.addFile(
-        'src/app/api/rate-limit-test/route.ts',
-        () => `
-        import { auth } from '@clerk/nextjs/server';
-
-        export async function GET(request: Request) {
-          const { userId, tokenType } = await auth({ acceptsToken: 'api_key' });
-
-          if (!userId) {
-            const reason = request.headers.get('x-clerk-auth-reason');
-            return Response.json({ error: 'Unauthorized', reason }, { status: 401 });
-          }
-
-          return Response.json({ userId, tokenType });
-        }
-        `,
-      ),
-  },
 };
 
 test.describe('Next.js machine authentication @machine', () => {
   registerApiKeyAuthTests(adapter);
   registerM2MAuthTests(adapter);
   registerOAuthAuthTests(adapter);
-  registerRateLimitTests(adapter);
 });