Skip to content

Commit 970335e

Browse files
committed
Introduce SP labels per provider
1 parent 43b2f1c commit 970335e

3 files changed

Lines changed: 34 additions & 18 deletions

File tree

packages/localizations/src/en-US.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -338,14 +338,6 @@ export const enUS: LocalizationResource = {
338338
},
339339
},
340340
configureStep: {
341-
spFields: {
342-
acsUrl: {
343-
label: 'Single sign-on URL',
344-
},
345-
spEntityId: {
346-
label: 'Audience URI',
347-
},
348-
},
349341
attributeMapping: {
350342
title: 'We expect your SAML responses to have the following specific attributes:',
351343
paragraph:
@@ -376,6 +368,14 @@ export const enUS: LocalizationResource = {
376368
},
377369
samlOkta: {
378370
headerTitle: 'Configure Okta Workforce',
371+
spFields: {
372+
acsUrl: {
373+
label: 'Single sign-on URL',
374+
},
375+
spEntityId: {
376+
label: 'Audience URI (SP Entity ID)',
377+
},
378+
},
379379
createApp: {
380380
headerSubtitle: 'Create a new enterprise application in your Okta Dashboard',
381381
title: 'Create a new enterprise application in Okta',
@@ -464,6 +464,14 @@ export const enUS: LocalizationResource = {
464464
},
465465
samlCustom: {
466466
headerTitle: 'Configure your identity provider (IdP)',
467+
spFields: {
468+
acsUrl: {
469+
label: 'Assertion consumer service (ACS) URL',
470+
},
471+
spEntityId: {
472+
label: 'Service provider entity ID',
473+
},
474+
},
467475
createApp: {
468476
headerSubtitle:
469477
'Register Clerk as a service provider in your IdP, then add your identity provider configuration.',

packages/shared/src/types/localization.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,14 +1397,6 @@ export type __internal_LocalizationResource = {
13971397
};
13981398
};
13991399
configureStep: {
1400-
spFields: {
1401-
acsUrl: {
1402-
label: LocalizationValue;
1403-
};
1404-
spEntityId: {
1405-
label: LocalizationValue;
1406-
};
1407-
};
14081400
attributeMapping: {
14091401
title: LocalizationValue;
14101402
paragraph: LocalizationValue;
@@ -1434,6 +1426,14 @@ export type __internal_LocalizationResource = {
14341426
};
14351427
samlOkta: {
14361428
headerTitle: LocalizationValue;
1429+
spFields: {
1430+
acsUrl: {
1431+
label: LocalizationValue;
1432+
};
1433+
spEntityId: {
1434+
label: LocalizationValue;
1435+
};
1436+
};
14371437
createApp: {
14381438
headerSubtitle: LocalizationValue;
14391439
title: LocalizationValue;
@@ -1518,6 +1518,14 @@ export type __internal_LocalizationResource = {
15181518
};
15191519
samlCustom: {
15201520
headerTitle: LocalizationValue;
1521+
spFields: {
1522+
acsUrl: {
1523+
label: LocalizationValue;
1524+
};
1525+
spEntityId: {
1526+
label: LocalizationValue;
1527+
};
1528+
};
15211529
createApp: {
15221530
headerSubtitle: LocalizationValue;
15231531
title: LocalizationValue;

packages/ui/src/components/ConfigureSSO/steps/ConfigureStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,12 @@ export const CreateAppSubStep = (): JSX.Element => {
163163

164164
const acsUrlField = useFormControl('acsUrl', acsUrl, {
165165
type: 'text',
166-
label: localizationKeys('configureSSO.configureStep.spFields.acsUrl.label'),
166+
label: localizationKeys(key('spFields.acsUrl.label')),
167167
isRequired: false,
168168
});
169169
const spEntityIdField = useFormControl('spEntityId', spEntityId, {
170170
type: 'text',
171-
label: localizationKeys('configureSSO.configureStep.spFields.spEntityId.label'),
171+
label: localizationKeys(key('spFields.spEntityId.label')),
172172
isRequired: false,
173173
});
174174

0 commit comments

Comments
 (0)