Skip to content

Commit 977daa4

Browse files
authored
refactor(clerk-js): Using snakeToCamel for signal field errors (#6638)
1 parent 377f67b commit 977daa4

2 files changed

Lines changed: 8 additions & 37 deletions

File tree

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/clerk-js/src/core/signals.ts

Lines changed: 6 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { isClerkAPIResponseError } from '@clerk/shared/error';
2+
import { snakeToCamel } from '@clerk/shared/underscore';
23
import type { Errors, SignInSignal, SignUpSignal } from '@clerk/types';
34
import { computed, signal } from 'alien-signals';
45

@@ -69,44 +70,12 @@ function errorsToParsedErrors(error: unknown): Errors {
6970

7071
error.errors.forEach(error => {
7172
if ('meta' in error && error.meta && 'paramName' in error.meta) {
72-
switch (error.meta.paramName) {
73-
case 'first_name':
74-
parsedErrors.fields.firstName = error;
75-
break;
76-
case 'last_name':
77-
parsedErrors.fields.lastName = error;
78-
break;
79-
case 'email_address':
80-
parsedErrors.fields.emailAddress = error;
81-
break;
82-
case 'identifier':
83-
parsedErrors.fields.identifier = error;
84-
break;
85-
case 'phone_number':
86-
parsedErrors.fields.phoneNumber = error;
87-
break;
88-
case 'password':
89-
parsedErrors.fields.password = error;
90-
break;
91-
case 'username':
92-
parsedErrors.fields.username = error;
93-
break;
94-
case 'code':
95-
parsedErrors.fields.code = error;
96-
break;
97-
case 'captcha':
98-
parsedErrors.fields.captcha = error;
99-
break;
100-
case 'legal_accepted':
101-
parsedErrors.fields.legalAccepted = error;
102-
break;
103-
default:
104-
parsedErrors.global.push(error);
105-
break;
106-
}
107-
} else {
108-
parsedErrors.global.push(error);
73+
const name = snakeToCamel(error.meta.paramName);
74+
parsedErrors.fields[name as keyof typeof parsedErrors.fields] = error;
75+
return;
10976
}
77+
78+
parsedErrors.global.push(error);
11079
});
11180

11281
return parsedErrors;

0 commit comments

Comments
 (0)