chore: initial test fix

Author: wobsoriano

packages/clerk-js/src/ui/components/GoogleOneTap/one-tap-start.tsx

@@ -66,8 +66,19 @@ function OneTapStartInternal(): JSX.Element | null {
   useEffect(() => {
     if (initializedGoogle && !user?.id && !isPromptedRef.current) {
       initializedGoogle.accounts.id.prompt(notification => {
-        // Close the modal, when the user clicks outside the prompt or cancels
-        if (notification.getMomentType() === 'skipped') {
+        // Support both FedCM and legacy modes
+        let shouldClose = false;
+
+        // FedCM-compatible check (preferred)
+        if ('isSkippedMoment' in notification && typeof notification.isSkippedMoment === 'function') {
+          shouldClose = notification.isSkippedMoment();
+        }
+        // Legacy check (fallback for non-FedCM browsers)
+        else if ('getMomentType' in notification && typeof notification.getMomentType === 'function') {
+          shouldClose = notification.getMomentType() === 'skipped';
+        }
+
+        if (shouldClose) {
           // Unmounts the component will cause the useEffect cleanup function from below to be called
           clerk.closeGoogleOneTap();
         }

packages/clerk-js/src/utils/one-tap.ts

@@ -15,13 +15,34 @@ interface InitializeProps {
   use_fedcm_for_prompt?: boolean;
 }
 
+// Legacy (deprecated in FedCM mode)
 interface PromptMomentNotification {
-  getMomentType: () => 'display' | 'skipped' | 'dismissed';
+  getMomentType?: () => 'display' | 'skipped' | 'dismissed';
 }
 
+// FedCM-compatible
+interface FedCMNotification {
+  isDisplayed?: () => boolean;
+  isNotDisplayed?: () => boolean;
+  getNotDisplayedReason?: () =>
+    | 'browser_not_supported'
+    | 'invalid_client'
+    | 'missing_client_id'
+    | 'opt_out_or_no_session'
+    | 'secure_http_required'
+    | 'suppressed_by_user'
+    | 'unregistered_origin'
+    | 'unknown_reason';
+  isSkippedMoment?: () => boolean;
+  getSkippedReason?: () => 'auto_cancel' | 'user_cancel' | 'tap_outside' | 'issuing_failed';
+}
+
+// Unified type supporting both
+type PromptNotification = PromptMomentNotification & FedCMNotification;
+
 interface OneTapMethods {
   initialize: (params: InitializeProps) => void;
-  prompt: (promptListener: (promptMomentNotification: PromptMomentNotification) => void) => void;
+  prompt: (promptListener: (promptMomentNotification: PromptNotification) => void) => void;
   cancel: () => void;
 }
 

packages/shared/src/types/clerk.ts

@@ -1518,10 +1518,16 @@ export type GoogleOneTapProps = GoogleOneTapRedirectUrlProps & {
    */
   itpSupport?: boolean;
   /**
-   * FedCM enables more private sign-in flows without requiring the use of third-party cookies.
-   * The browser controls user settings, displays user prompts, and only contacts an Identity Provider such as Google after explicit user consent is given.
-   * Backwards compatible with browsers that still support third-party cookies.
+   * FedCM enables more private sign-in flows without requiring third-party cookies.
+   * The browser controls user settings, displays user prompts, and only contacts
+   * an Identity Provider such as Google after explicit user consent.
    *
+   * When enabled:
+   * - Uses browser-native FedCM API (Chrome 116+, Edge 116+)
+   * - Falls back to legacy mode in unsupported browsers
+   * - Requires HTTPS in production
+   *
+   * @see https://developers.google.com/identity/gsi/web/guides/fedcm-migration
    * @default true
    */
   fedCmSupport?: boolean;