Skip to content

Commit abbc6c4

Browse files
authored
fix(ci): sanitize artifact name to remove invalid colon characters (#8189)
1 parent b8c73d3 commit abbc6c4

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

.changeset/fix-ci-artifact-name.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.github/workflows/ci.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,11 +457,20 @@ jobs:
457457
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
458458
VERCEL_AUTOMATION_BYPASS_SECRET: ${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }}
459459

460+
- name: Sanitize artifact name
461+
if: ${{ cancelled() || failure() }}
462+
id: sanitize
463+
run: |
464+
SANITIZED="${TEST_NAME//:/-}"
465+
echo "artifact-suffix=${SANITIZED}" >> $GITHUB_OUTPUT
466+
env:
467+
TEST_NAME: ${{ matrix.test-name }}
468+
460469
- name: Upload test-results
461470
if: ${{ cancelled() || failure() }}
462471
uses: actions/upload-artifact@v4
463472
with:
464-
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}
473+
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ steps.sanitize.outputs.artifact-suffix }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}
465474
path: test-results
466475
retention-days: 1
467476

0 commit comments

Comments
 (0)