Skip to content

Commit b193f79

Browse files
authored
fix(clerk-js,ui,react,shared): Standardize TaskSetupMFA naming across the codebase (#7859)
1 parent 42e8455 commit b193f79

6 files changed

Lines changed: 24 additions & 17 deletions

File tree

.changeset/fair-banks-attack.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@clerk/clerk-js': minor
3+
'@clerk/shared': minor
4+
'@clerk/react': minor
5+
---
6+
7+
Renames `mountTaskSetupMfa` and `unmountTaskSetupMfa` to `mountTaskSetupMFA` and `unmountTaskSetupMFA` respectively

packages/clerk-js/sandbox/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ void (async () => {
422422
);
423423
},
424424
'/task-setup-mfa': () => {
425-
Clerk.mountTaskSetupMfa(
425+
Clerk.mountTaskSetupMFA(
426426
app,
427427
componentControls.taskSetupMFA.getProps() ?? {
428428
redirectUrlComplete: '/user-profile',

packages/clerk-js/src/core/clerk.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1444,7 +1444,7 @@ export class Clerk implements ClerkInterface {
14441444
void this.#clerkUI?.then(ui => ui.ensureMounted()).then(controls => controls.unmountComponent({ node }));
14451445
};
14461446

1447-
public mountTaskSetupMfa = (node: HTMLDivElement, props?: TaskSetupMFAProps) => {
1447+
public mountTaskSetupMFA = (node: HTMLDivElement, props?: TaskSetupMFAProps) => {
14481448
this.assertComponentsReady(this.#clerkUI);
14491449

14501450
const component = 'TaskSetupMFA';
@@ -1459,10 +1459,10 @@ export class Clerk implements ClerkInterface {
14591459
}),
14601460
);
14611461

1462-
this.telemetry?.record(eventPrebuiltComponentMounted('TaskSetupMfa', props));
1462+
this.telemetry?.record(eventPrebuiltComponentMounted('TaskSetupMFA', props));
14631463
};
14641464

1465-
public unmountTaskSetupMfa = (node: HTMLDivElement) => {
1465+
public unmountTaskSetupMFA = (node: HTMLDivElement) => {
14661466
void this.#clerkUI?.then(ui => ui.ensureMounted()).then(controls => controls.unmountComponent({ node }));
14671467
};
14681468

packages/react/src/components/uiComponents.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -742,8 +742,8 @@ export const TaskSetupMFA = withClerk(
742742
{clerk.loaded && (
743743
<ClerkHostRenderer
744744
component={component}
745-
mount={clerk.mountTaskSetupMfa}
746-
unmount={clerk.unmountTaskSetupMfa}
745+
mount={clerk.mountTaskSetupMFA}
746+
unmount={clerk.unmountTaskSetupMFA}
747747
updateProps={(clerk as any).__internal_updateProps}
748748
props={props}
749749
rootProps={rendererRootProps}

packages/react/src/isomorphicClerk.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
158158
private premountOAuthConsentNodes = new Map<HTMLDivElement, __internal_OAuthConsentProps | undefined>();
159159
private premountTaskChooseOrganizationNodes = new Map<HTMLDivElement, TaskChooseOrganizationProps | undefined>();
160160
private premountTaskResetPasswordNodes = new Map<HTMLDivElement, TaskResetPasswordProps | undefined>();
161-
private premountTaskSetupMfaNodes = new Map<HTMLDivElement, TaskSetupMFAProps | undefined>();
161+
private premountTaskSetupMFANodes = new Map<HTMLDivElement, TaskSetupMFAProps | undefined>();
162162
// A separate Map of `addListener` method calls to handle multiple listeners.
163163
private premountAddListenerCalls = new Map<
164164
ListenerCallback,
@@ -707,8 +707,8 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
707707
clerkjs.mountTaskResetPassword(node, props);
708708
});
709709

710-
this.premountTaskSetupMfaNodes.forEach((props, node) => {
711-
clerkjs.mountTaskSetupMfa(node, props);
710+
this.premountTaskSetupMFANodes.forEach((props, node) => {
711+
clerkjs.mountTaskSetupMFA(node, props);
712712
});
713713

714714
/**
@@ -1275,19 +1275,19 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {
12751275
}
12761276
};
12771277

1278-
mountTaskSetupMfa = (node: HTMLDivElement, props?: TaskSetupMFAProps): void => {
1278+
mountTaskSetupMFA = (node: HTMLDivElement, props?: TaskSetupMFAProps): void => {
12791279
if (this.clerkjs && this.loaded) {
1280-
this.clerkjs.mountTaskSetupMfa(node, props);
1280+
this.clerkjs.mountTaskSetupMFA(node, props);
12811281
} else {
1282-
this.premountTaskSetupMfaNodes.set(node, props);
1282+
this.premountTaskSetupMFANodes.set(node, props);
12831283
}
12841284
};
12851285

1286-
unmountTaskSetupMfa = (node: HTMLDivElement): void => {
1286+
unmountTaskSetupMFA = (node: HTMLDivElement): void => {
12871287
if (this.clerkjs && this.loaded) {
1288-
this.clerkjs.unmountTaskSetupMfa(node);
1288+
this.clerkjs.unmountTaskSetupMFA(node);
12891289
} else {
1290-
this.premountTaskSetupMfaNodes.delete(node);
1290+
this.premountTaskSetupMFANodes.delete(node);
12911291
}
12921292
};
12931293

packages/shared/src/types/clerk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,15 +721,15 @@ export interface Clerk {
721721
* @param targetNode - Target node to mount the TaskSetupMFA component.
722722
* @param props - configuration parameters.
723723
*/
724-
mountTaskSetupMfa: (targetNode: HTMLDivElement, props?: TaskSetupMFAProps) => void;
724+
mountTaskSetupMFA: (targetNode: HTMLDivElement, props?: TaskSetupMFAProps) => void;
725725

726726
/**
727727
* Unmount a TaskSetupMFA component from the target element.
728728
* If there is no component mounted at the target node, results in a noop.
729729
*
730730
* @param targetNode - Target node to unmount the TaskSetupMFA component from.
731731
*/
732-
unmountTaskSetupMfa: (targetNode: HTMLDivElement) => void;
732+
unmountTaskSetupMFA: (targetNode: HTMLDivElement) => void;
733733

734734
/**
735735
* @internal

0 commit comments

Comments
 (0)