Skip to content

Commit e86b0ef

Browse files
committed
chore(repo): Fix keyless E2E tests
1 parent 6e90b7f commit e86b0ef

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

integration/tests/next-quickstart-keyless.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,20 +89,20 @@ test.describe('Keyless mode @quickstart', () => {
8989
await newPage.waitForLoadState();
9090

9191
await newPage.waitForURL(url => {
92-
const urlToReturnTo = `${dashboardUrl}apps/claim?token=`;
93-
92+
const signInForceRedirectUrl = url.searchParams.get('sign_in_force_redirect_url');
9493
const signUpForceRedirectUrl = url.searchParams.get('sign_up_force_redirect_url');
9594

96-
const signUpForceRedirectUrlCheck =
97-
signUpForceRedirectUrl?.startsWith(urlToReturnTo) ||
95+
// Parse the redirect URLs to check structure instead of using startsWith
96+
const signInRedirectHasClaimToken =
97+
signInForceRedirectUrl && new URL(signInForceRedirectUrl).searchParams.has('token');
98+
99+
const signUpRedirectIsValid =
100+
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}apps/claim`) &&
101+
new URL(signUpForceRedirectUrl).searchParams.has('token')) ||
98102
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
99103
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim?token=')));
100104

101-
return (
102-
url.pathname === '/apps/claim/sign-in' &&
103-
url.searchParams.get('sign_in_force_redirect_url')?.startsWith(urlToReturnTo) &&
104-
signUpForceRedirectUrlCheck
105-
);
105+
return url.pathname === '/apps/claim/sign-in' && signInRedirectHasClaimToken && signUpRedirectIsValid;
106106
});
107107
});
108108

integration/tests/tanstack-start/keyless.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,20 @@ test.describe('Keyless mode @tanstack-react-start', () => {
6969
await newPage.waitForLoadState();
7070

7171
await newPage.waitForURL(url => {
72-
const urlToReturnTo = `${dashboardUrl}apps/claim?token=`;
73-
72+
const signInForceRedirectUrl = url.searchParams.get('sign_in_force_redirect_url');
7473
const signUpForceRedirectUrl = url.searchParams.get('sign_up_force_redirect_url');
7574

76-
const signUpForceRedirectUrlCheck =
77-
signUpForceRedirectUrl?.startsWith(urlToReturnTo) ||
75+
// Parse the redirect URLs to check structure instead of using startsWith
76+
const signInRedirectHasClaimToken =
77+
signInForceRedirectUrl && new URL(signInForceRedirectUrl).searchParams.has('token');
78+
79+
const signUpRedirectIsValid =
80+
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}apps/claim`) &&
81+
new URL(signUpForceRedirectUrl).searchParams.has('token')) ||
7882
(signUpForceRedirectUrl?.startsWith(`${dashboardUrl}prepare-account`) &&
7983
signUpForceRedirectUrl?.includes(encodeURIComponent('apps/claim?token=')));
8084

81-
return (
82-
url.pathname === '/apps/claim/sign-in' &&
83-
url.searchParams.get('sign_in_force_redirect_url')?.startsWith(urlToReturnTo) &&
84-
signUpForceRedirectUrlCheck
85-
);
85+
return url.pathname === '/apps/claim/sign-in' && signInRedirectHasClaimToken && signUpRedirectIsValid;
8686
});
8787
});
8888

0 commit comments

Comments
 (0)