Skip to content

Commit ed6dc98

Browse files
committed
ci(expo): pass exclude_tags via env to avoid shell injection
1 parent 28fb6bc commit ed6dc98

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/mobile-e2e.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ jobs:
126126
env:
127127
CLERK_TEST_EMAIL: ${{ steps.user.outputs.email }}
128128
CLERK_TEST_PASSWORD: ${{ steps.user.outputs.password }}
129+
EXCLUDE_TAGS: ${{ inputs.exclude_tags }}
129130
with:
130131
api-level: 34
131132
target: google_apis
@@ -137,7 +138,7 @@ jobs:
137138
cd ../../integration-mobile
138139
# Maestro doesn't auto-recurse into subdirectories; pass each flow explicitly.
139140
find flows -type f -name "*.yaml" ! -path "*/common/*" -print0 | \
140-
xargs -0 maestro test --exclude-tags "${{ inputs.exclude_tags }}"
141+
xargs -0 maestro test --exclude-tags "$EXCLUDE_TAGS"
141142
142143
- name: Upload Maestro artifacts on failure
143144
if: failure()
@@ -241,14 +242,15 @@ jobs:
241242
env:
242243
CLERK_TEST_EMAIL: ${{ steps.user.outputs.email }}
243244
CLERK_TEST_PASSWORD: ${{ steps.user.outputs.password }}
245+
EXCLUDE_TAGS: ${{ inputs.exclude_tags }}
244246
run: |
245247
cd clerk-expo-quickstart/NativeComponentQuickstart
246248
npx expo prebuild --clean
247249
npx expo run:ios --configuration Release --no-bundler
248250
cd ../../integration-mobile
249251
# Maestro doesn't auto-recurse into subdirectories; pass each flow explicitly.
250252
find flows -type f -name "*.yaml" ! -path "*/common/*" -print0 | \
251-
xargs -0 maestro test --exclude-tags "${{ inputs.exclude_tags }},androidOnly"
253+
xargs -0 maestro test --exclude-tags "$EXCLUDE_TAGS,androidOnly"
252254
253255
- name: Upload Maestro artifacts on failure
254256
if: failure()

0 commit comments

Comments
 (0)