Skip to content

Commit efc34b4

Browse files
committed
Introduce SP labels per provider
1 parent 64ef4ff commit efc34b4

3 files changed

Lines changed: 34 additions & 18 deletions

File tree

packages/localizations/src/en-US.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -338,14 +338,6 @@ export const enUS: LocalizationResource = {
338338
},
339339
},
340340
configureStep: {
341-
spFields: {
342-
acsUrl: {
343-
label: 'Single sign-on URL',
344-
},
345-
spEntityId: {
346-
label: 'Audience URI',
347-
},
348-
},
349341
attributeMapping: {
350342
title: 'We expect your SAML responses to have the following specific attributes:',
351343
paragraph:
@@ -376,6 +368,14 @@ export const enUS: LocalizationResource = {
376368
},
377369
samlOkta: {
378370
headerTitle: 'Configure Okta Workforce',
371+
spFields: {
372+
acsUrl: {
373+
label: 'Single sign-on URL',
374+
},
375+
spEntityId: {
376+
label: 'Audience URI (SP Entity ID)',
377+
},
378+
},
379379
createApp: {
380380
headerSubtitle: 'Create a new enterprise application in your Okta Dashboard',
381381
title: 'Create a new enterprise application in Okta',
@@ -464,6 +464,14 @@ export const enUS: LocalizationResource = {
464464
},
465465
samlCustom: {
466466
headerTitle: 'Configure your identity provider (IdP)',
467+
spFields: {
468+
acsUrl: {
469+
label: 'Assertion consumer service (ACS) URL',
470+
},
471+
spEntityId: {
472+
label: 'Service provider entity ID',
473+
},
474+
},
467475
createApp: {
468476
headerSubtitle:
469477
'Register Clerk as a service provider in your IdP, then add your identity provider configuration.',

packages/shared/src/types/localization.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1398,14 +1398,6 @@ export type __internal_LocalizationResource = {
13981398
};
13991399
};
14001400
configureStep: {
1401-
spFields: {
1402-
acsUrl: {
1403-
label: LocalizationValue;
1404-
};
1405-
spEntityId: {
1406-
label: LocalizationValue;
1407-
};
1408-
};
14091401
attributeMapping: {
14101402
title: LocalizationValue;
14111403
paragraph: LocalizationValue;
@@ -1435,6 +1427,14 @@ export type __internal_LocalizationResource = {
14351427
};
14361428
samlOkta: {
14371429
headerTitle: LocalizationValue;
1430+
spFields: {
1431+
acsUrl: {
1432+
label: LocalizationValue;
1433+
};
1434+
spEntityId: {
1435+
label: LocalizationValue;
1436+
};
1437+
};
14381438
createApp: {
14391439
headerSubtitle: LocalizationValue;
14401440
title: LocalizationValue;
@@ -1519,6 +1519,14 @@ export type __internal_LocalizationResource = {
15191519
};
15201520
samlCustom: {
15211521
headerTitle: LocalizationValue;
1522+
spFields: {
1523+
acsUrl: {
1524+
label: LocalizationValue;
1525+
};
1526+
spEntityId: {
1527+
label: LocalizationValue;
1528+
};
1529+
};
15221530
createApp: {
15231531
headerSubtitle: LocalizationValue;
15241532
title: LocalizationValue;

packages/ui/src/components/ConfigureSSO/steps/ConfigureStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,12 @@ export const CreateAppSubStep = (): JSX.Element => {
163163

164164
const acsUrlField = useFormControl('acsUrl', acsUrl, {
165165
type: 'text',
166-
label: localizationKeys('configureSSO.configureStep.spFields.acsUrl.label'),
166+
label: localizationKeys(key('spFields.acsUrl.label')),
167167
isRequired: false,
168168
});
169169
const spEntityIdField = useFormControl('spEntityId', spEntityId, {
170170
type: 'text',
171-
label: localizationKeys('configureSSO.configureStep.spFields.spEntityId.label'),
171+
label: localizationKeys(key('spFields.spEntityId.label')),
172172
isRequired: false,
173173
});
174174

0 commit comments

Comments
 (0)