Commit f07722e
committed
fix(astro): Pass options to clerkClient and remove unused parameters
Fix unused parameters and ensure options are properly passed through the
call chain, matching React Router's pattern exactly.
Changes:
1. clerk-client.ts:
- Update clerkClient signature to accept optional options parameter
- Now matches React Router: clerkClient(context, options?)
- Allows keyless service to override client configuration
2. keyless/index.ts:
- Pass options parameter to clerkClient() calls
- Options now used in createAccountlessApplication
- Options now used in completeOnboarding
- Fixes unused parameter warning
3. clerk-middleware.ts:
- Remove unused 'error' variable in catch block
- Use empty catch block (matches React Router pattern)
4. keyless/utils.ts:
- Fix import sorting (ESLint auto-fix)
Benefits:
✅ No unused parameters
✅ Options properly passed through call chain
✅ clerkClient can be overridden with custom config
✅ Matches React Router pattern exactly
✅ All ESLint errors resolved
✅ All TypeScript type checks pass1 parent 2ed5c1a commit f07722e
4 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| |||
56 | 59 | | |
57 | 60 | | |
58 | 61 | | |
| 62 | + | |
59 | 63 | | |
60 | 64 | | |
61 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments