fix(clerk-js,shared): Improve ticket and SSO types for Future APIs (#8267)

Author: dstaley

.changeset/famous-needles-laugh.md

@@ -0,0 +1,6 @@
+---
+'@clerk/clerk-js': patch
+'@clerk/shared': patch
+---
+
+Improve types for `signIn.create` and `signUp.create` methods.

packages/clerk-js/src/core/resources/SignIn.ts

@@ -1145,11 +1145,13 @@ class SignInFuture implements SignInFutureResource {
         routes.actionCompleteRedirectUrl = wrappedRoutes.redirectUrl;
       }
 
-      await this._create({
-        strategy,
-        ...routes,
-        identifier,
-      });
+      if (!this.#resource.id) {
+        await this._create({
+          strategy,
+          ...routes,
+          identifier,
+        });
+      }
 
       if (strategy === 'enterprise_sso') {
         await this.#resource.__internal_basePost({

packages/clerk-js/src/core/resources/SignUp.ts

@@ -1026,21 +1026,22 @@ class SignUpFuture implements SignUpFutureResource {
       }
 
       const authenticateFn = () => {
-        return this.#resource.__internal_basePost({
-          path: this.#resource.pathRoot,
-          body: {
-            strategy,
-            ...routes,
-            unsafeMetadata,
-            legalAccepted,
-            oidcPrompt,
-            enterpriseConnectionId,
-            emailAddress,
-            captchaToken,
-            captchaWidgetType,
-            captchaError,
-          },
-        });
+        const body: Record<string, unknown> = {
+          strategy,
+          ...routes,
+          unsafeMetadata,
+          legalAccepted,
+          oidcPrompt,
+          enterpriseConnectionId,
+          emailAddress,
+          captchaToken,
+          captchaWidgetType,
+          captchaError,
+        };
+        if (this.#resource.id) {
+          return this.#resource.__internal_basePatch({ path: this.#resource.pathRoot, body });
+        }
+        return this.#resource.__internal_basePost({ path: this.#resource.pathRoot, body });
       };
 
       await authenticateFn().catch(async e => {

packages/shared/src/types/signInFuture.ts

@@ -2,7 +2,7 @@ import type { ClerkError } from '../errors/clerkError';
 import type { SetActiveNavigate } from './clerk';
 import type { PhoneCodeChannel } from './phoneCodeChannel';
 import type { SignInFirstFactor, SignInSecondFactor, SignInStatus, UserData } from './signInCommon';
-import type { OAuthStrategy, PasskeyStrategy, Web3Strategy } from './strategies';
+import type { OAuthStrategy, PasskeyStrategy, TicketStrategy, Web3Strategy } from './strategies';
 import type { VerificationResource } from './verification';
 import type { Web3Provider } from './web3';
 
@@ -12,11 +12,16 @@ export interface SignInFutureCreateParams {
    * username, or Web3 wallet address.
    */
   identifier?: string;
+  /**
+   * The user's password. Only supported if
+   * [password](https://clerk.com/docs/guides/configure/auth-strategies/sign-up-sign-in-options#password) is enabled.
+   */
+  password?: string;
   /**
    * The first factor verification strategy to use in the sign-in flow. Depends on the `identifier` value. Each
    * authentication identifier supports different verification strategies.
    */
-  strategy?: OAuthStrategy | 'enterprise_sso' | PasskeyStrategy;
+  strategy?: OAuthStrategy | 'enterprise_sso' | PasskeyStrategy | TicketStrategy;
   /**
    * The full URL or path that the OAuth provider should redirect to after successful authorization on their part.
    */

packages/shared/src/types/signUpFuture.ts

@@ -2,7 +2,15 @@ import type { ClerkError } from '../errors/clerkError';
 import type { SetActiveNavigate } from './clerk';
 import type { PhoneCodeChannel } from './phoneCodeChannel';
 import type { SignUpField, SignUpIdentificationField, SignUpStatus, SignUpVerificationResource } from './signUpCommon';
-import type { Web3Strategy } from './strategies';
+import type {
+  AppleIdTokenStrategy,
+  EnterpriseSSOStrategy,
+  GoogleOneTapStrategy,
+  OAuthStrategy,
+  PhoneCodeStrategy,
+  TicketStrategy,
+  Web3Strategy,
+} from './strategies';
 import type { VerificationResource } from './verification';
 
 export interface SignUpFutureAdditionalParams {
@@ -38,6 +46,17 @@ export interface SignUpFutureAdditionalParams {
 }
 
 export interface SignUpFutureCreateParams extends SignUpFutureAdditionalParams {
+  /**
+   * The first factor verification strategy to use in the sign-in flow. Depends on the `identifier` value. Each
+   * authentication identifier supports different verification strategies.
+   */
+  strategy?:
+    | OAuthStrategy
+    | EnterpriseSSOStrategy
+    | TicketStrategy
+    | GoogleOneTapStrategy
+    | AppleIdTokenStrategy
+    | PhoneCodeStrategy;
   /**
    * The user's email address. Only supported if [Email address](https://clerk.com/docs/guides/configure/auth-strategies/sign-up-sign-in-options#email)
    * is enabled. Keep in mind that the email address requires an extra verification process.
@@ -55,6 +74,11 @@ export interface SignUpFutureCreateParams extends SignUpFutureAdditionalParams {
    * the instance settings.
    */
   username?: string;
+  /**
+   * The user's password. Only supported if
+   * [password](https://clerk.com/docs/guides/configure/auth-strategies/sign-up-sign-in-options#password) is enabled.
+   */
+  password?: string;
   /**
    * When set to `true`, the `SignUp` will attempt to retrieve information from the active `SignIn` instance and use it
    * to complete the sign-up process. This is useful when you want to seamlessly transition a user from a sign-in