Skip to content

fix(ci): Fix membership check for private members#7993

Merged
dominic-clerk merged 1 commit intomainfrom
dc-fix-membership-check
Mar 5, 2026
Merged

fix(ci): Fix membership check for private members#7993
dominic-clerk merged 1 commit intomainfrom
dc-fix-membership-check

Conversation

@dominic-clerk
Copy link
Copy Markdown
Contributor

@dominic-clerk dominic-clerk commented Mar 5, 2026

Description

Private members of the organization cannot be fetched with checkMembershipForUser unless the caller is an org admin. We want this job to also allow private members to run snapshot jobs. This PR also adds the requirement that the user is an active member.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: CI

Summary by CodeRabbit

  • Chores
    • Enhanced release workflow validation to enforce stricter membership verification during the release process.

Private members of the organization cannot be fetched with
checkMembershipForUser unless the caller is an org admin. We want this
job to also allow private members to run snapshot jobs. This PR also
adds the requirement that the user is an active member.
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 5, 2026 11:30am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: d51eca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3b1f13da-0968-43ac-99ac-bacd20b24e6b

📥 Commits

Reviewing files that changed from the base of the PR and between a8061d6 and d51eca5.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The changes modify the organization membership validation logic in the release workflow. The API call for checking membership is updated to retrieve full membership data and validate that the membership state is explicitly 'active'. If the state is not 'active', the workflow fails with a specific error message. The change maintains backward compatibility with the existing error handling for users who are not members. The modification affects two snapshot-related workflow steps with a net change of 4 lines added and 1 line removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(ci): Fix membership check for private members' directly addresses the main change in the PR, which modifies the CI membership check logic to handle private organization members correctly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 5, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7993

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7993

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7993

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7993

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7993

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7993

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7993

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7993

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7993

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7993

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7993

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7993

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7993

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7993

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7993

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7993

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7993

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7993

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7993

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7993

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7993

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7993

commit: d51eca5

@dominic-clerk dominic-clerk enabled auto-merge (squash) March 5, 2026 11:34
@dominic-clerk dominic-clerk merged commit a001946 into main Mar 5, 2026
41 checks passed
@dominic-clerk dominic-clerk deleted the dc-fix-membership-check branch March 5, 2026 11:42
@dominic-clerk
Copy link
Copy Markdown
Contributor Author

!snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants