fix(ci): Fix membership check for private members#7993
Conversation
Private members of the organization cannot be fetched with checkMembershipForUser unless the caller is an org admin. We want this job to also allow private members to run snapshot jobs. This PR also adds the requirement that the user is an active member.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes modify the organization membership validation logic in the release workflow. The API call for checking membership is updated to retrieve full membership data and validate that the membership state is explicitly 'active'. If the state is not 'active', the workflow fails with a specific error message. The change maintains backward compatibility with the existing error handling for users who are not members. The modification affects two snapshot-related workflow steps with a net change of 4 lines added and 1 line removed. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
!snapshot |
Description
Private members of the organization cannot be fetched with checkMembershipForUser unless the caller is an org admin. We want this job to also allow private members to run snapshot jobs. This PR also adds the requirement that the user is an active member.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit