Skip to content

experiment: revert rspack 1.7.x pin to test e2e impact#8425

Closed
jacekradko wants to merge 1 commit intomainfrom
jacek/revert-rspack-pin-experiment
Closed

experiment: revert rspack 1.7.x pin to test e2e impact#8425
jacekradko wants to merge 1 commit intomainfrom
jacek/revert-rspack-pin-experiment

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Do not merge. Sandbox to verify whether reverting #8378 (pin rspack to 1.7.x and disable lazy compilation) flips the consistently-failing express / hono / generic / nextjs / billing / machine integration suites back to green.

Hypothesis: `disable lazy compilation` + the older rspack pin may produce a chunk graph that takes longer to deliver under heavy CI parallelism, contributing to the userButton mount-timeout failures.

Sibling experiments: #8423 (revert PR 8035 auto-proxy), #8424 (revert PR 8351 Node 24).
Related: #8422 (the actual fix PR currently open).

Will be closed regardless of outcome.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: d73e6ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 30, 2026 3:57am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

📝 Walkthrough

Walkthrough

This change migrates rspack dependency management from a centralized pnpm workspace catalog to explicit semver version ranges in individual package.json files. The rspack catalog is deleted from pnpm-workspace.yaml, with @rspack/cli and @rspack/core pinned to ^1.6.0 in clerk-js and ^1.7.11 in ui, and @rspack/plugin-react-refresh updated to ^1.6.2 in ui only. Additionally, lazyCompilation: false settings are removed from rspack configuration files in both packages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting an rspack pin and disabling lazy compilation changes to test their e2e impact.
Description check ✅ Passed The description is directly related to the changeset, explaining the experiment's purpose, hypothesis, and context within the broader investigation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 2/5 reviews remaining, refill in 24 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/clerk-js/package.json (1)

104-116: ⚠️ Potential issue | 🔴 Critical

Restore @rspack/plugin-react-refresh in devDependencies.

packages/clerk-js/rspack.config.js directly requires @rspack/plugin-react-refresh, but it's not declared in this package's devDependencies. This will cause build failures when the dependency resolution changes. Add it to match the pattern in packages/ui/package.json, which correctly declares it as "@rspack/plugin-react-refresh": "^1.6.2".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/clerk-js/package.json` around lines 104 - 116, The package is
missing the devDependency referenced by rspack.config.js: add
"@rspack/plugin-react-refresh" to the "devDependencies" object in this
package.json (matching the pattern used in packages/ui) with version "^1.6.2" so
require('@rspack/plugin-react-refresh') resolves; update the devDependencies
entry and reinstall dev deps (npm/yarn/pnpm install) to prevent build failures
when dependency resolution changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/clerk-js/package.json`:
- Around line 104-116: The package is missing the devDependency referenced by
rspack.config.js: add "@rspack/plugin-react-refresh" to the "devDependencies"
object in this package.json (matching the pattern used in packages/ui) with
version "^1.6.2" so require('@rspack/plugin-react-refresh') resolves; update the
devDependencies entry and reinstall dev deps (npm/yarn/pnpm install) to prevent
build failures when dependency resolution changes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e7cc7f7e-8f98-4691-aa2b-7e3df82f6170

📥 Commits

Reviewing files that changed from the base of the PR and between 61e0a78 and d73e6ab.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
💤 Files with no reviewable changes (3)
  • packages/ui/rspack.config.js
  • packages/clerk-js/rspack.config.js
  • pnpm-workspace.yaml

@jacekradko
Copy link
Copy Markdown
Member Author

Closing — user clarified that #8378 (pin rspack 1.7.x + disable lazy compilation) was a fix for an earlier rspack regression, not the current one. Will test Rspack 2 upgrade instead in a new experiment.

@jacekradko jacekradko closed this Apr 30, 2026
@jacekradko jacekradko deleted the jacek/revert-rspack-pin-experiment branch April 30, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant