Skip to content

chore(e2e): retire vite trusted-publisher override#8526

Open
jacekradko wants to merge 2 commits into
mainfrom
jacek/bump-vite
Open

chore(e2e): retire vite trusted-publisher override#8526
jacekradko wants to merge 2 commits into
mainfrom
jacek/bump-vite

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Follow-up to #8522. Bumps vite direct dependencies to ^7.3.3 across nine integration test templates and two playground apps that were previously on vite 4/5/6/7.0, then drops the vite@<7.1.3 entry from root pnpm.overrides and from TRUSTED_OVERRIDES in integration/constants.ts.

vite 7.1.3 is the first version published via OIDC trusted publisher. @vitejs/plugin-react@^4 supports vite 4 through 7 so plugin versions don't need to move alongside. Fixture vite configs are minimal defineConfig({ plugins: [react()] }) and aren't affected by 4→7 breaking changes. Validated locally with workspace pnpm install and an isolated fixture install + build smoke test of react-vite.

Bumps vite direct deps to ^7.3.3 across nine fixture templates and two
playground apps that were previously on vite 4/5/6/7.0, then drops the
corresponding entry from root pnpm.overrides and TRUSTED_OVERRIDES.
vite 7.1.3 is the first version published via OIDC trusted publisher.

@vitejs/plugin-react@^4 supports vite 4-7 so plugin versions don't need
to move. Fixture vite configs are minimal defineConfig({ plugins: [react()] })
and unaffected by 4→7 breaking changes.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

🦋 Changeset detected

Latest commit: a126b02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 12, 2026 6:29am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7909d5bb-6b6b-42e8-9c91-6e363f40f076

📥 Commits

Reviewing files that changed from the base of the PR and between 4818414 and a126b02.

📒 Files selected for processing (2)
  • integration/templates/react-vite/package.json
  • integration/templates/vue-vite/package.json
✅ Files skipped from review due to trivial changes (1)
  • integration/templates/react-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • integration/templates/vue-vite/package.json

📝 Walkthrough

Walkthrough

This PR removes the global vite override (pnpm.overrides and TRUSTED_OVERRIDES) and updates direct devDependencies to vite ^7.3.3 across integration templates and playgrounds. It also updates @vitejs/plugin-vue and @types/node where present and adds a .changeset documenting the change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: retiring a vite trusted-publisher override by bumping vite dependencies and removing override entries.
Description check ✅ Passed The description is directly related to the changeset, providing context about the vite dependency bumps, the removal of overrides, and validation of changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@integration/templates/vue-vite/package.json`:
- Around line 16-18: The package.json currently pins "@vitejs/plugin-vue":
"^5.1.4" which is incompatible with "vite": "^7.3.3"; update the dependency to a
version that supports Vite 7 (e.g. change "@vitejs/plugin-vue" to "^6.0.0" or
later) so the template can build with Vite 7.3.3 and regenerate/install
lockfiles as needed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 29470f5d-3bb1-4c7f-ac13-5a8ff967c2f7

📥 Commits

Reviewing files that changed from the base of the PR and between c5fd14c and 4818414.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (13)
  • .changeset/retire-vite-override.md
  • integration/constants.ts
  • integration/templates/chrome-extension-vite/package.json
  • integration/templates/custom-flows-react-vite/package.json
  • integration/templates/express-vite/package.json
  • integration/templates/fastify-vite/package.json
  • integration/templates/hono-vite/package.json
  • integration/templates/react-router-library/package.json
  • integration/templates/react-vite/package.json
  • integration/templates/vue-vite/package.json
  • package.json
  • playground/react-router/package.json
  • playground/vite-react-ts/package.json
💤 Files with no reviewable changes (1)
  • integration/constants.ts

Comment thread integration/templates/vue-vite/package.json Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8526

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8526

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8526

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8526

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8526

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8526

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8526

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8526

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8526

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8526

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8526

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8526

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8526

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8526

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8526

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8526

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8526

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8526

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8526

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8526

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8526

commit: a126b02

vite 7 declares peerOptional @types/node "^20.19.0 || >=22.12.0", which
the react-vite template's ^18.19.33 pin fails under npm's strict resolution
(pkglab uses npm internally). Bumps that template's @types/node to ^22.12.0.

vue-vite was on @vitejs/plugin-vue ^5.1.4, which only supports vite 5/6.
Bumps it to ^6.0.0 for vite 7 support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant