Fix a missing test when access a uninitialized property in the cypher key storage after adding typed properties

johnkrovitch · johnkrovitch · commit 47120372341a · 2020-11-26T11:18:37.000+01:00
diff --git a/src/Session/CipherKeyStorage.php b/src/Session/CipherKeyStorage.php
@@ -61,7 +61,7 @@ public function setCipherKey(string $cipherKey): void
      */
     public function getCipherKey(): string
     {
-        if (!$this->cipherKey) {
+        if (!isset($this->cipherKey) || !$this->cipherKey) {
             $this->cipherKey = hex2bin($this->session->get(self::SESSION_CIPHER_KEY));
         }
         if (!trim($this->cipherKey)) {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function setCipherKey(string $cipherKey): void`
`61`	`61`	`*/`
`62`	`62`	`public function getCipherKey(): string`
`63`	`63`	`{`
`64`		`- if (!$this->cipherKey) {`
	`64`	`+ if (!isset($this->cipherKey) \|\| !$this->cipherKey) {`
`65`	`65`	`$this->cipherKey = hex2bin($this->session->get(self::SESSION_CIPHER_KEY));`
`66`	`66`	`}`
`67`	`67`	`if (!trim($this->cipherKey)) {`