#8 Apply phpstan level 10

Author: njoubert-cleverage

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 6
+    level: 10
     paths:
         - src
         - tests

src/Client/Client.php

@@ -23,25 +23,20 @@
 class Client implements ClientInterface
 {
     /** @var array<mixed>|null */
-    private $soapOptions;
+    private ?array $soapOptions = null;
 
     /** @var \SoapHeader[]|null */
-    private $soapHeaders;
+    private ?array $soapHeaders = null;
 
-    /** @var \SoapClient */
-    private $soapClient;
+    private ?\SoapClient $soapClient = null;
 
-    /** @var string */
-    private $lastRequest;
+    private ?string $lastRequest = null;
 
-    /** @var string */
-    private $lastRequestHeaders;
+    private ?string $lastRequestHeaders = null;
 
-    /** @var string */
-    private $lastResponse;
+    private ?string $lastResponse = null;
 
-    /** @var string */
-    private $lastResponseHeaders;
+    private ?string $lastResponseHeaders = null;
 
     /**
      * Client constructor.
@@ -231,11 +226,12 @@ protected function initializeSoapClient(): void
 
     protected function getLastRequestTrace(): void
     {
-        if ($this->getSoapClient() instanceof \SoapClient) {
-            $this->setLastRequest($this->getSoapClient()->__getLastRequest());
-            $this->setLastRequestHeaders($this->getSoapClient()->__getLastRequestHeaders());
-            $this->setLastResponse($this->getSoapClient()->__getLastResponse());
-            $this->setLastResponseHeaders($this->getSoapClient()->__getLastResponseHeaders());
+        $soapClient = $this->getSoapClient();
+        if ($soapClient instanceof \SoapClient) {
+            $this->setLastRequest($soapClient->__getLastRequest());
+            $this->setLastRequestHeaders($soapClient->__getLastRequestHeaders());
+            $this->setLastResponse($soapClient->__getLastResponse());
+            $this->setLastResponseHeaders($soapClient->__getLastResponseHeaders());
         }
     }
 

src/Task/RequestTask.php

@@ -21,6 +21,14 @@
 use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @phpstan-type RequestOptions array{
+ *     'client': string,
+ *     'method': string,
+ *     'soap_call_options': array<mixed>|null,
+ *     'soap_call_headers': array<\SoapHeader>|null,
+ *  }
+ */
 class RequestTask extends AbstractConfigurableTask
 {
     public function __construct(protected LoggerInterface $logger, protected ClientRegistry $registry)
@@ -29,15 +37,20 @@ public function __construct(protected LoggerInterface $logger, protected ClientR
 
     public function execute(ProcessState $state): void
     {
+        /** @var RequestOptions $options */
         $options = $this->getOptions($state);
 
         $client = $this->registry->getClient($options['client']);
 
         /** @var array<mixed> $input */
         $input = $state->getInput() ?: [];
 
-        $client->setSoapOptions($this->getOption($state, 'soap_call_options'));
-        $client->setSoapHeaders($this->getOption($state, 'soap_call_headers'));
+        /** @var array<mixed>|null $soapCallOptions */
+        $soapCallOptions = $this->getOption($state, 'soap_call_options');
+        $client->setSoapOptions($soapCallOptions);
+        /** @var array<\SoapHeader>|null $soapCallHeaders */
+        $soapCallHeaders = $this->getOption($state, 'soap_call_headers');
+        $client->setSoapHeaders($soapCallHeaders);
 
         $result = $client->call($options['method'], $input);
 
@@ -93,7 +106,9 @@ protected function configureOptions(OptionsResolver $resolver): void
             $this->configureSoapCallHeaderOption($headerResolver);
 
             $resolvedHeaders = [];
+            /** @var array<string, array<mixed>> $headers */
             foreach ($headers as $name => $header) {
+                /** @var array{'namespace': string, 'data': array<mixed>} $resolvedHeader */
                 $resolvedHeader = $headerResolver->resolve($header);
                 $resolvedHeaders[] = new \SoapHeader($resolvedHeader['namespace'], $name, $resolvedHeader['data']);
             }

src/Transformer/RequestTransformer.php

@@ -18,7 +18,7 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * @phpstan-type Options array{
+ * @phpstan-type TransformerOptions array{
  *       'client': string,
  *       'method': string,
  *  }
@@ -34,9 +34,13 @@ public function __construct(protected ClientRegistry $registry)
      */
     public function transform(mixed $value, array $options = []): mixed
     {
+        if (!\is_array($value)) {
+            throw new \UnexpectedValueException('Expecting an array of value');
+        }
+
         $resolver = new OptionsResolver();
         $this->configureOptions($resolver);
-        /** @var Options $options */
+        /** @var TransformerOptions $options */
         $options = $resolver->resolve($options);
 
         $client = $this->registry->getClient($options['client']);