#8 Remove all phpstan ignoreErrors. Fix code.

Author: njoubert-cleverage

phpstan.neon

@@ -3,16 +3,3 @@ parameters:
     paths:
         - src
         - tests
-    ignoreErrors:
-        - '#type has no value type specified in iterable type#'
-        - '#has parameter .* with no value type specified in iterable type#'
-        - '#has no value type specified in iterable type array#'
-        - '#configureOptions\(\) has no return type specified.#'
-        - '#configure\(\) has no return type specified#'
-        - '#process\(\) has no return type specified#'
-        - '#should return Iterator but returns Traversable#'
-        - '#Negated boolean expression is always false#'
-    checkGenericClassInNonGenericObjectType: false
-    reportUnmatchedIgnoredErrors: false
-    inferPrivatePropertyTypeFromConstructor: true
-    treatPhpDocTypesAsCertain: false

src/Client/Client.php

@@ -22,7 +22,7 @@
  */
 class Client implements ClientInterface
 {
-    /** @var array */
+    /** @var array<mixed>|null */
     private $soapOptions;
 
     /** @var \SoapHeader[]|null */
@@ -50,6 +50,7 @@ public function __construct(
         private readonly LoggerInterface $logger,
         private readonly string $code,
         private ?string $wsdl,
+        /** @var array<mixed> */
         private array $options = [],
     ) {
     }
@@ -167,9 +168,6 @@ public function setLastResponseHeaders(?string $lastResponseHeaders): void
         $this->lastResponseHeaders = $lastResponseHeaders;
     }
 
-    /**
-     * @return bool|mixed
-     */
     public function call(string $method, array $input = []): mixed
     {
         $this->initializeSoapClient();
@@ -187,6 +185,8 @@ public function call(string $method, array $input = []): mixed
     }
 
     /**
+     * @param array<mixed> $input
+     *
      * @return bool|mixed
      */
     protected function doSoapCall(string $method, array $input = []): mixed
@@ -196,7 +196,7 @@ protected function doSoapCall(string $method, array $input = []): mixed
         }
         try {
             $result = $this->getSoapClient()->__soapCall($method, $input, $this->getSoapOptions(), $this->getSoapHeaders());
-        } /* @noinspection PhpRedundantCatchClauseInspection */ catch (\SoapFault $e) {
+        } catch (\SoapFault $e) {
             $this->getLastRequestTrace();
             $this->getLogger()->alert(
                 \sprintf("Soap call '%s' on '%s' failed : %s", $method, $this->getWsdl(), $e->getMessage()),
@@ -239,6 +239,14 @@ protected function getLastRequestTrace(): void
         }
     }
 
+    /**
+     * @return array{
+     *     'LastRequest': ?string,
+     *     'LastRequestHeaders': ?string,
+     *     'LastResponse': ?string,
+     *     'LastResponseHeaders': ?string
+     * }
+     */
     protected function getLastRequestTraceArray(): array
     {
         return [

src/Client/ClientInterface.php

@@ -34,27 +34,35 @@ public function setWsdl(?string $wsdl): void;
      * Return the Soap client options.
      *
      * @see http://php.net/manual/en/soapclient.soapclient.php
+     *
+     * @return array<mixed>
      */
     public function getOptions(): array;
 
     /**
      * Set the Soap client options.
      *
      * @see http://php.net/manual/en/soapclient.soapclient.php
+     *
+     * @param array<mixed> $options
      */
     public function setOptions(array $options): void;
 
     /**
      * Return the Soap call options.
      *
      * @see https://www.php.net/manual/en/soapclient.soapcall.php
+     *
+     * @return array<mixed>|null
      */
     public function getSoapOptions(): ?array;
 
     /**
      * Set the Soap call options.
      *
      * @see https://www.php.net/manual/en/soapclient.soapcall.php
+     *
+     * @param array<mixed>|null $options
      */
     public function setSoapOptions(?array $options = null): void;
 
@@ -87,6 +95,8 @@ public function getLastResponseHeaders(): ?string;
     /**
      * Call Soap method.
      *
+     * @param array<mixed> $input
+     *
      * @return bool|mixed
      */
     public function call(string $method, array $input = []): mixed;

src/Task/RequestTask.php

@@ -33,6 +33,7 @@ public function execute(ProcessState $state): void
 
         $client = $this->registry->getClient($options['client']);
 
+        /** @var array<mixed> $input */
         $input = $state->getInput() ?: [];
 
         $client->setSoapOptions($this->getOption($state, 'soap_call_options'));

src/Transformer/RequestTransformer.php

@@ -17,16 +17,26 @@
 use CleverAge\SoapProcessBundle\Registry\ClientRegistry;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @phpstan-type Options array{
+ *       'client': string,
+ *       'method': string,
+ *  }
+ */
 class RequestTransformer implements ConfigurableTransformerInterface
 {
     public function __construct(protected ClientRegistry $registry)
     {
     }
 
+    /**
+     * @param array<mixed> $options
+     */
     public function transform(mixed $value, array $options = []): mixed
     {
         $resolver = new OptionsResolver();
         $this->configureOptions($resolver);
+        /** @var Options $options */
         $options = $resolver->resolve($options);
 
         $client = $this->registry->getClient($options['client']);