[Refactor] Apply consts to store Regexes on lib/active_record/connection_adapters/pinot_adapter.rb#3
Open
carlosdanielpohlod wants to merge 2 commits into
Conversation
…on? SQL functions
carlosdanielpohlod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
-> Applied regex to give a meaningful name for each regex on
extract_value_from_default-> Applied a
CONSTwith comments to explain what thehas_default_function?is looking for-> Using ::Regexp.last_match ensures explicit, safer access to regex matches, avoiding reliance on mutable global variables like $1 and improving code readability and maintainability