Skip to content

[Refactor] Apply consts to store Regexes on lib/active_record/connection_adapters/pinot_adapter.rb #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosdanielpohlod wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Refactor] Apply consts to store Regexes on lib/active_record/connection_adapters/pinot_adapter.rb #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8607b2d
add regex for extract_value_from_default regex and has_default_funct…
carlosdanielpohlod Apr 12, 2025
fb9d62b
use ::Regexp instead global variable as $1 and $&
carlosdanielpohlod Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions lib/active_record/connection_adapters/pinot_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ def pinot_connection(config)

module ConnectionAdapters
class PinotAdapter < AbstractAdapter
NULL_REGEX = /^null$/i
SINGLE_QUOTED_STRING_REGEX = /^'([^|]*)'$/m
DOUBLE_QUOTED_STRING_REGEX = /^"([^|]*)"$/m
NUMERIC_REGEX = /\A-?\d+(\.\d*)?\z/
BINARY_HEX_REGEX = /x'(.*)'/
# Matches SQL functions or expressions (e.g., NOW(), CURRENT_DATE, or string concatenation)
SQL_FUNCTION_OR_EXPRESSION_REGEX = %r{
\w+\(.*\) | # SQL functions like NOW(), uuid_generate_v4(), etc.
CURRENT_TIME | # special SQL keyword
CURRENT_DATE | # special SQL keyword
CURRENT_TIMESTAMP | # special SQL keyword
\|\| # SQL string concatenation operator
}x

TYPES = {
"INT" => Type::Integer.new,
"TIMESTAMP" => Type::DateTime.new,
Expand All @@ -21,6 +35,7 @@ class PinotAdapter < AbstractAdapter
"STRING" => Type::String.new,
"JSON" => ActiveRecord::Type::Json.new
}

def initialize(config = {})
@pinot_host = config.fetch(:host)
@pinot_port = config.fetch(:port)
Expand Down Expand Up @@ -84,24 +99,16 @@ def new_column_from_field(table_name, field, definitions = nil)

def extract_value_from_default(default)
case default
when /^null$/i
nil
# Quoted types
when /^'([^|]*)'$/m
$1.gsub("''", "'")
# Quoted types
when /^"([^|]*)"$/m
$1.gsub('""', '"')
# Numeric types
when /\A-?\d+(\.\d*)?\z/
$&
# Binary columns
when /x'(.*)'/
[$1].pack("H*")
else
# Anything else is blank or some function
# and we can't know the value of that, so return nil.
when NULL_REGEX
nil
when SINGLE_QUOTED_STRING_REGEX
::Regexp.last_match(1).gsub("''", "'")
when DOUBLE_QUOTED_STRING_REGEX
::Regexp.last_match(1).gsub('""', '"')
when NUMERIC_REGEX
::Regexp.last_match(0)
when BINARY_HEX_REGEX
[::Regexp.last_match(1)].pack('H*')
end
end

Expand All @@ -110,7 +117,7 @@ def extract_default_function(default_value, default)
end

def has_default_function?(default_value, default)
!default_value && %r{\w+\(.*\)|CURRENT_TIME|CURRENT_DATE|CURRENT_TIMESTAMP|\|\|}.match?(default)
!default_value && SQL_FUNCTION_OR_EXPRESSION_REGEX.match?(default)
end

INTEGER_REGEX = /integer/i
Expand Down