feat: bookmarks search

[dhimanAbhi]

Related Issue

Closes #959

What does this PR do?

Adds a new whodb-cli bookmarks search [pattern] command to filter saved bookmarks by name and SQL query text.

Why?

Currently, users must scan all bookmarks manually using list. This becomes inefficient as the number of bookmarks grows. This feature enables quick lookup by name or query content.

How it works

The user can use this command by passing an arguement of a bookmark's name or query. The command filters from existing bookmarks and returns results.

Usage

whodb-cli bookmarks search pattern

How was this tested?

Manual testing:

./whodb-cli bookmarks list 
name    query
get-str-table   SELECT * FROM strtab
get-rec SELECT * FROM strtab
get-age SELECT age FROM strtab
get-age-gt-ten  SELECT age FROM strtab

whodb-cli bookmarks search age --format json
[
  {
    "name": "get-age",
    "query": "SELECT age FROM strtab"
  },
  {
    "name": "get-age-gt-ten",
    "query": "SELECT age FROM strtab"
  }
]

whodb-cli bookmarks search SELECT
name    query
get-str-table   SELECT * FROM strtab
get-rec SELECT * FROM strtab
get-age SELECT age FROM strtab
get-age-gt-ten  SELECT age FROM strtab

whodb-cli bookmarks search SELECT --format json
[
  {
    "name": "get-str-table",
    "query": "SELECT * FROM strtab"
  },
  {
    "name": "get-rec",
    "query": "SELECT * FROM strtab"
  },
  {
    "name": "get-age",
    "query": "SELECT age FROM strtab"
  },
  {
    "name": "get-age-gt-ten",
    "query": "SELECT age FROM strtab"
  }
]

./whodb-cli bookmarks search sdfds --format json
[]

Screenshots / recordings

Checklist

• I have read the Contributing Guidelines
• I discussed this change in an issue before starting work
• My PR description is written in my own words and accurately describes my changes
• I have tested my changes locally
• I have not included build artifacts or unrelated changes

[modelorona]

@dhimanAbhi this looks like a duplicate of #973, is that intended or did you mean to only open that one?

[renezander030]

Hi @dhimanAbhi,

Three things from reading the diff:

1. Stray backtick in the Short description: Short: "Search saved bookmarks\",— the trailing backtick will show up in--help` output.

2. The acceptance criteria on #959 calls for tests covering name match, query match, no match, and JSON output. The current diff doesn't add any. The other CLI commands in cli/cmd/ have programmatic tests in programmatic_commands_test.go that you could mirror.

3. strings.ReplaceAll(value.Query, "\n", " ") is applied to the row before passing to WriteQueryResult, which means the JSON output also returns the newlines-collapsed query rather than the original SQL. Worth keeping the original value.Query in the row and letting the table renderer be the one that flattens whitespace for display only.

Also re modelorona's comment about #973 being a duplicate — if that one is intended as the canonical PR it might be worth closing one of them to unblock the review.

Thanks for the work on this.