feat: json error preview#989
Open
dhimanAbhi wants to merge 2 commits into
Open
Conversation
Signed-off-by: Abhishek Dhiman <abhi2002dhiman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #951
What does this PR do?
The JSON preview in the editor no longer crashes the app when the input is invalid, it now shows an inline error message instead.
How it works
A readable inline error message is rendered in the preview area instead when an invalid JSON is previewed by user.
How was this tested?
Connected to a MongoDB database, opened the Add Row sheet, entered invalid JSON, clicked Show Preview and confirmed the inline error message appears without crashing the app.
Screenshots / recordings
Checklist