Apply suggestions from code review

Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: Shubham Mishra <shivam828787@gmail.com>

Author: Shubham8287

crates/core/src/db/relational_db.rs

@@ -819,7 +819,7 @@ impl RelationalDB {
             Txdata,
         };
 
-        let is_ephemeral_tables = |table_id: &TableId| -> bool {
+        let is_ephemeral_table = |table_id: &TableId| -> bool {
             tx_data
                 .ephemeral_tables()
                 .map(|etables| etables.contains(table_id))
@@ -2566,7 +2566,7 @@ mod tests {
             Bytes::from(to_vec(&AlgebraicValue::Array([pv.clone()].into())).expect("bstan serialization failed"))
         };
 
-        let row_pv = |v: u8| ProductValue::from_iter(vec![AlgebraicValue::U8(v)]);
+        let row_pv = |v: u8| product![v];
 
         let mut tx = begin_mut_tx(stdb);
         tx.subscribe_view(view_id, ArgId::SENTINEL, sender)?;

crates/datastore/src/locking_tx_datastore/committed_state.rs

@@ -81,7 +81,7 @@ pub struct CommittedState {
     /// and its read set will be updated accordingly.
     read_sets: ViewReadSets,
 
-    /// Tables which do not needs to be made persistent.
+    /// Tables which do not need to be made persistent.
     /// These include:
     ///     - system tables: `st_view_sub`, `st_view_arg`
     ///     - Tables which back views.