Extract spacetimedb-memory-usage & Nix bindings dep on spacetimedb-data-structures (#2919)

Author: Centril

Cargo.lock

@@ -108,6 +108,7 @@ spacetimedb-durability = { path = "crates/durability", version = "1.2.0" }
 spacetimedb-execution = { path = "crates/execution", version = "1.2.0" }
 spacetimedb-expr = { path = "crates/expr", version = "1.2.0" }
 spacetimedb-lib = { path = "crates/lib", default-features = false, version = "1.2.0" }
+spacetimedb-memory-usage = { path = "crates/memory-usage", version = "1.2.0", default-features = false }
 spacetimedb-metrics = { path = "crates/metrics", version = "1.2.0" }
 spacetimedb-paths = { path = "crates/paths", version = "1.2.0" }
 spacetimedb-physical-plan = { path = "crates/physical-plan", version = "1.2.0" }

Cargo.toml

@@ -2,7 +2,7 @@
 source: crates/bindings/tests/deps.rs
 expression: "cargo tree -p spacetimedb -f {lib} -e no-dev"
 ---
-total crates: 66
+total crates: 61
 spacetimedb
 ├── bytemuck
 ├── derive_more
@@ -69,22 +69,6 @@ spacetimedb
 │   ├── hex
 │   ├── itertools (*)
 │   ├── spacetimedb_bindings_macro (*)
-│   ├── spacetimedb_data_structures
-│   │   ├── ahash
-│   │   │   ├── cfg_if
-│   │   │   ├── once_cell
-│   │   │   └── zerocopy
-│   │   │   [build-dependencies]
-│   │   │   └── version_check
-│   │   ├── hashbrown
-│   │   │   └── equivalent
-│   │   ├── nohash_hasher
-│   │   ├── smallvec
-│   │   └── thiserror
-│   │       └── thiserror_impl
-│   │           ├── proc_macro2 (*)
-│   │           ├── quote (*)
-│   │           └── syn (*)
 │   ├── spacetimedb_primitives (*)
 │   ├── spacetimedb_sats
 │   │   ├── anyhow
@@ -117,8 +101,11 @@ spacetimedb
 │   │   │   └── keccak
 │   │   ├── smallvec
 │   │   ├── spacetimedb_bindings_macro (*)
-│   │   ├── spacetimedb_data_structures (*)
 │   │   ├── spacetimedb_primitives (*)
-│   │   └── thiserror (*)
+│   │   └── thiserror
+│   │       └── thiserror_impl
+│   │           ├── proc_macro2 (*)
+│   │           ├── quote (*)
+│   │           └── syn (*)
 │   └── thiserror (*)
 └── spacetimedb_primitives (*)

crates/bindings/tests/snapshots/deps__spacetimedb_bindings_dependencies.snap

@@ -70,12 +70,12 @@ error[E0277]: the reducer argument `Test` does not implement `SpacetimeType`
   = help: the following other types implement trait `SpacetimeType`:
             &T
             ()
+            AlgebraicType
             AlgebraicTypeRef
             Arc<T>
             ArrayType
             Box<T>
             ColId
-            ColumnAttribute
           and $N others
   = note: required for `Test` to implement `ReducerArg`
 

crates/bindings/tests/ui/reducers.stderr

@@ -21,12 +21,12 @@ error[E0277]: the column type `Test` does not implement `SpacetimeType`
   = help: the following other types implement trait `SpacetimeType`:
             &T
             ()
+            AlgebraicType
             AlgebraicTypeRef
             Alpha
             Arc<T>
             ArrayType
             Box<T>
-            ColId
           and $N others
   = note: required for `Test` to implement `TableColumn`
 
@@ -40,12 +40,12 @@ error[E0277]: the trait bound `Test: SpacetimeType` is not satisfied
   = help: the following other types implement trait `SpacetimeType`:
             &T
             ()
+            AlgebraicType
             AlgebraicTypeRef
             Alpha
             Arc<T>
             ArrayType
             Box<T>
-            ColId
           and $N others
 
 error[E0277]: the trait bound `Test: Deserialize<'de>` is not satisfied
@@ -61,11 +61,11 @@ error[E0277]: the trait bound `Test: Deserialize<'de>` is not satisfied
             &'de [u8]
             &'de str
             ()
+            AlgebraicType
             AlgebraicTypeRef
             Alpha
             Arc<[T]>
             ArrayType
-            Box<T>
           and $N others
 note: required by a bound in `spacetimedb::spacetimedb_lib::de::SeqProductAccess::next_element`
  --> $WORKSPACE/crates/sats/src/de.rs
@@ -83,11 +83,11 @@ error[E0277]: the trait bound `Test: Deserialize<'_>` is not satisfied
             &'de [u8]
             &'de str
             ()
+            AlgebraicType
             AlgebraicTypeRef
             Alpha
             Arc<[T]>
             ArrayType
-            Box<T>
           and $N others
 note: required by a bound in `get_field_value`
  --> $WORKSPACE/crates/sats/src/de.rs
@@ -104,12 +104,12 @@ error[E0277]: the trait bound `Test: Serialize` is not satisfied
   = help: the following other types implement trait `Serialize`:
             &T
             ()
+            AlgebraicType
             AlgebraicTypeRef
+            AlgebraicValue
             Alpha
             Arc<T>
             ArrayType
-            ArrayValue
-            Bound<T>
           and $N others
 note: required by a bound in `spacetimedb::spacetimedb_lib::ser::SerializeNamedProduct::serialize_element`
  --> $WORKSPACE/crates/sats/src/ser.rs
@@ -135,7 +135,7 @@ error[E0277]: `&'a Alpha` cannot appear as an argument to an index filtering ope
              &bool
              &ethnum::int::I256
            and $N others
-note: required by a bound in `UniqueColumn::<Tbl, <Col as spacetimedb::table::Column>::ColType, Col>::find`
+note: required by a bound in `UniqueColumn::<Tbl, <Col as Column>::ColType, Col>::find`
   --> src/table.rs
    |
    |     pub fn find(&self, col_val: impl Borrow<Col::ColType>) -> Option<Tbl::Row>

crates/bindings/tests/ui/tables.stderr

@@ -21,6 +21,7 @@ spacetimedb-lib = { workspace = true, features = ["serde", "metrics_impls"] }
 spacetimedb-client-api-messages.workspace = true
 spacetimedb-commitlog.workspace = true
 spacetimedb-durability.workspace = true
+spacetimedb-memory-usage.workspace = true
 spacetimedb-metrics.workspace = true
 spacetimedb-primitives.workspace = true
 spacetimedb-paths.workspace = true

crates/core/Cargo.toml

@@ -1,15 +1,11 @@
 use super::system_tables::SystemTable;
 use enum_as_inner::EnumAsInner;
-use spacetimedb_lib::buffer::DecodeError;
-use spacetimedb_lib::{
-    db::{
-        error::LibError,
-        raw_def::{v9::RawSql, RawIndexDefV8},
-    },
-    AlgebraicType, AlgebraicValue, ProductValue,
-};
+use spacetimedb_lib::db::raw_def::{v9::RawSql, RawIndexDefV8};
 use spacetimedb_primitives::{ColId, ColList, IndexId, SequenceId, TableId};
+use spacetimedb_sats::buffer::DecodeError;
 use spacetimedb_sats::{product_value::InvalidFieldError, satn::Satn};
+use spacetimedb_sats::{AlgebraicType, AlgebraicValue, ProductValue};
+use spacetimedb_schema::def::error::LibError;
 use spacetimedb_snapshot::SnapshotError;
 use spacetimedb_table::{
     bflatn_to, read_column,

crates/core/src/db/datastore/error.rs

@@ -16,11 +16,11 @@ use thiserror::Error;
 use crate::client::ClientActorId;
 use crate::host::scheduler::ScheduleError;
 use spacetimedb_lib::buffer::DecodeError;
-use spacetimedb_lib::db::error::{LibError, RelationError, SchemaErrors};
-use spacetimedb_lib::relation::FieldName;
 use spacetimedb_primitives::*;
 use spacetimedb_sats::hash::Hash;
 use spacetimedb_sats::product_value::InvalidFieldError;
+use spacetimedb_schema::def::error::{LibError, RelationError, SchemaErrors};
+use spacetimedb_schema::relation::FieldName;
 use spacetimedb_vm::errors::{ErrorKind, ErrorLang, ErrorType, ErrorVm};
 use spacetimedb_vm::expr::Crud;
 

crates/core/src/error.rs

@@ -7,11 +7,11 @@ use spacetimedb_data_structures::map::{HashCollectionExt as _, IntMap};
 use spacetimedb_expr::check::SchemaView;
 use spacetimedb_expr::statement::compile_sql_stmt;
 use spacetimedb_lib::db::auth::StAccess;
-use spacetimedb_lib::db::error::RelationError;
 use spacetimedb_lib::identity::AuthCtx;
-use spacetimedb_lib::relation::{ColExpr, FieldName};
 use spacetimedb_primitives::{ColId, TableId};
 use spacetimedb_sats::{AlgebraicType, AlgebraicValue};
+use spacetimedb_schema::def::error::RelationError;
+use spacetimedb_schema::relation::{ColExpr, FieldName};
 use spacetimedb_schema::schema::{ColumnSchema, TableSchema};
 use spacetimedb_vm::errors::ErrorVm;
 use spacetimedb_vm::expr::{Expr, FieldExpr, FieldOp};

crates/core/src/sql/ast.rs

@@ -7,8 +7,8 @@ use crate::error::{DBError, PlanError};
 use core::ops::Deref;
 use spacetimedb_data_structures::map::IntMap;
 use spacetimedb_lib::identity::AuthCtx;
-use spacetimedb_lib::relation::{self, ColExpr, DbTable, FieldName, Header};
 use spacetimedb_primitives::ColId;
+use spacetimedb_schema::relation::{self, ColExpr, DbTable, FieldName, Header};
 use spacetimedb_schema::schema::TableSchema;
 use spacetimedb_vm::expr::{CrudExpr, Expr, FieldExpr, QueryExpr, SourceExpr};
 use spacetimedb_vm::operator::OpCmp;