Skip to content

Commit 1fa49c1

Browse files
committed
Rename energy_used->execution_budget_used generally
1 parent 8705546 commit 1fa49c1

12 files changed

Lines changed: 35 additions & 34 deletions

File tree

crates/client-api/src/routes/database.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ pub async fn call<S: ControlStateDelegate + NodeDelegate>(
202202
let (status, body) = reducer_outcome_response(&owner_identity, &reducer, result.outcome);
203203
Ok((
204204
status,
205-
TypedHeader(SpacetimeEnergyUsed(result.energy_used)),
205+
TypedHeader(SpacetimeEnergyUsed(result.execution_budget_used)),
206206
TypedHeader(SpacetimeExecutionDurationMicros(result.execution_duration)),
207207
body,
208208
)

crates/core/src/client/message_handlers_v1.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ impl MessageExecutionError {
139139
},
140140
status: EventStatus::FailedInternal(format!("{:#}", err)),
141141
reducer_return_value: None,
142-
execution_energy_used: FunctionBudget::ZERO,
142+
execution_budget_used: FunctionBudget::ZERO,
143143
host_execution_duration: Duration::ZERO,
144144
request_id: Some(RequestId::default()),
145145
timer: None,

crates/core/src/client/messages.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ impl ToProtocol for TransactionUpdateMessage {
440440
// elsewhere. So, we just pretend that this is `EnergyQuanta` when it's actually
441441
// a different unit, and it doesn't really matter to the client anyway.
442442
// TODO(noa): maybe we could just have this be zero, unconditionally?
443-
energy_quanta_used: EnergyQuanta::new(event.execution_energy_used.get().into()),
443+
energy_quanta_used: EnergyQuanta::new(event.execution_budget_used.get().into()),
444444
total_host_execution_duration: event.host_execution_duration.into(),
445445
caller_connection_id: event.caller_connection_id.unwrap_or(ConnectionId::ZERO),
446446
};

crates/core/src/energy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ pub trait EnergyMonitor: Send + Sync + 'static {
1717
fn record_reducer(
1818
&self,
1919
fingerprint: &FunctionFingerprint<'_>,
20-
energy_used: FunctionBudget,
20+
execution_budget_used: FunctionBudget,
2121
execution_duration: Duration,
2222
);
2323
fn record_disk_usage(&self, database: &Database, replica_id: u64, disk_usage: u64, period: Duration);
@@ -36,7 +36,7 @@ impl EnergyMonitor for NullEnergyMonitor {
3636
fn record_reducer(
3737
&self,
3838
_fingerprint: &FunctionFingerprint<'_>,
39-
_energy_used: FunctionBudget,
39+
_execution_budget_used: FunctionBudget,
4040
_execution_duration: Duration,
4141
) {
4242
}

crates/core/src/host/host_controller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ impl HostRuntimes {
148148
#[derive(Clone, Debug)]
149149
pub struct ReducerCallResult {
150150
pub outcome: ReducerOutcome,
151-
pub energy_used: FunctionBudget,
151+
pub execution_budget_used: FunctionBudget,
152152
pub execution_duration: Duration,
153153
}
154154

crates/core/src/host/instance_env.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ impl InstanceEnv {
793793
request_id: None,
794794
timer: None,
795795
// The procedure will pick up the tab for the energy.
796-
execution_energy_used: FunctionBudget::ZERO,
796+
execution_budget_used: FunctionBudget::ZERO,
797797
host_execution_duration: Duration::from_millis(0),
798798
};
799799
// Commit the tx and broadcast it.

crates/core/src/host/module_host.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ pub struct ModuleEvent {
211211
pub function_call: ModuleFunctionCall,
212212
pub status: EventStatus,
213213
pub reducer_return_value: Option<Bytes>,
214-
pub execution_energy_used: FunctionBudget,
214+
pub execution_budget_used: FunctionBudget,
215215
pub host_execution_duration: Duration,
216216
pub request_id: Option<RequestId>,
217217
pub timer: Option<Instant>,
@@ -1481,7 +1481,7 @@ impl From<EventStatus> for ViewOutcome {
14811481
pub struct ViewCallResult {
14821482
pub outcome: ViewOutcome,
14831483
pub tx: MutTxId,
1484-
pub energy_used: FunctionBudget,
1484+
pub execution_budget_used: FunctionBudget,
14851485
pub total_duration: Duration,
14861486
pub abi_duration: Duration,
14871487
}
@@ -1490,7 +1490,7 @@ impl fmt::Debug for ViewCallResult {
14901490
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
14911491
f.debug_struct("ViewCallResult")
14921492
.field("outcome", &self.outcome)
1493-
.field("energy_used", &self.energy_used)
1493+
.field("execution_budget_used", &self.execution_budget_used)
14941494
.field("total_duration", &self.total_duration)
14951495
.field("abi_duration", &self.abi_duration)
14961496
.finish()
@@ -1501,7 +1501,7 @@ impl ViewCallResult {
15011501
pub fn default(tx: MutTxId) -> Self {
15021502
Self {
15031503
outcome: ViewOutcome::Success,
1504-
energy_used: FunctionBudget::ZERO,
1504+
execution_budget_used: FunctionBudget::ZERO,
15051505
total_duration: Duration::ZERO,
15061506
abi_duration: Duration::ZERO,
15071507
tx,
@@ -2932,7 +2932,7 @@ impl ModuleHost {
29322932
// Increment execution stats
29332933
tx = result.tx;
29342934
outcome = result.outcome;
2935-
energy_used += result.energy_used;
2935+
energy_used += result.execution_budget_used;
29362936
total_duration += result.total_duration;
29372937
abi_duration += result.abi_duration;
29382938
trapped |= trap;
@@ -2946,7 +2946,7 @@ impl ModuleHost {
29462946
ViewCallResult {
29472947
outcome,
29482948
tx,
2949-
energy_used,
2949+
execution_budget_used: energy_used,
29502950
total_duration,
29512951
abi_duration,
29522952
},

crates/core/src/host/scheduler.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ fn refresh_views_then_commit_and_broadcast(
693693
status,
694694
reducer_return_value: None,
695695
//Keeping them 0 as it is internal transaction, not by reducer
696-
execution_energy_used: FunctionBudget::ZERO,
696+
execution_budget_used: FunctionBudget::ZERO,
697697
host_execution_duration: Duration::from_millis(0),
698698
request_id: None,
699699
timer: None,

crates/core/src/host/wasm_common/module_host_actor.rs

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ pub struct ExecutionStats {
245245
}
246246

247247
impl ExecutionStats {
248-
fn energy_used(&self) -> FunctionBudget {
248+
fn execution_budget_used(&self) -> FunctionBudget {
249249
self.energy.used()
250250
}
251251

@@ -679,7 +679,7 @@ impl InstanceCommon {
679679
log::info!("Database updated, {} host-type={}", stdb.database_identity(), host_type);
680680

681681
let succeed = |info: Arc<ModuleInfo>,
682-
execution_energy_used: FunctionBudget,
682+
execution_budget_used: FunctionBudget,
683683
host_execution_duration: Duration,
684684
tx: MutTxId|
685685
-> TransactionOffset {
@@ -690,7 +690,7 @@ impl InstanceCommon {
690690
function_call: ModuleFunctionCall::update(),
691691
status: EventStatus::Committed(DatabaseUpdate::default()),
692692
reducer_return_value: None,
693-
execution_energy_used,
693+
execution_budget_used,
694694
host_execution_duration,
695695
request_id: None,
696696
timer: None,
@@ -726,7 +726,8 @@ impl InstanceCommon {
726726
stdb.report_mut_tx_metrics(reducer, tx_metrics, None);
727727
UpdateDatabaseResult::ErrorExecutingMigration(anyhow::anyhow!(msg))
728728
} else {
729-
let tx_offset = succeed(self.info.clone(), out.energy_used, out.total_duration, tx);
729+
let tx_offset =
730+
succeed(self.info.clone(), out.execution_budget_used, out.total_duration, tx);
730731
UpdateDatabaseResult::UpdatePerformed {
731732
tx_offset,
732733
durable_offset,
@@ -1063,7 +1064,7 @@ impl InstanceCommon {
10631064
};
10641065

10651066
// Account for view execution in reducer reporting metrics
1066-
vm_metrics.report_energy_used(out.energy_used);
1067+
vm_metrics.report_execution_budget_used(out.execution_budget_used);
10671068
vm_metrics.report_total_duration(out.total_duration);
10681069
vm_metrics.report_abi_duration(out.abi_duration);
10691070

@@ -1076,7 +1077,7 @@ impl InstanceCommon {
10761077
reducer_return_value = None;
10771078
}
10781079

1079-
let execution_energy_used = result.stats.energy_used();
1080+
let execution_budget_used = result.stats.execution_budget_used();
10801081
let total_duration = result.stats.total_duration();
10811082

10821083
let event = ModuleEvent {
@@ -1090,7 +1091,7 @@ impl InstanceCommon {
10901091
},
10911092
status,
10921093
reducer_return_value,
1093-
execution_energy_used,
1094+
execution_budget_used,
10941095
host_execution_duration: total_duration,
10951096
request_id,
10961097
timer,
@@ -1099,7 +1100,7 @@ impl InstanceCommon {
10991100

11001101
let res = ReducerCallResult {
11011102
outcome: ReducerOutcome::from(&event.status),
1102-
energy_used: execution_energy_used,
1103+
execution_budget_used,
11031104
execution_duration: total_duration,
11041105
};
11051106

@@ -1142,12 +1143,12 @@ impl InstanceCommon {
11421143
let result = vm_call_function(budget);
11431144

11441145
let stats: &ExecutionStats = result.as_ref();
1145-
let energy_used = stats.energy.used();
1146+
let execution_budget_used = stats.energy.used();
11461147
let timings = &stats.timings;
11471148
let memory_allocation = stats.memory_allocation;
11481149

11491150
self.energy_monitor
1150-
.record_reducer(&energy_fingerprint, energy_used, timings.total_duration);
1151+
.record_reducer(&energy_fingerprint, execution_budget_used, timings.total_duration);
11511152
if self.allocated_memory != memory_allocation {
11521153
self.metric_wasm_memory_bytes.set(memory_allocation as i64);
11531154
self.allocated_memory = memory_allocation;
@@ -1157,7 +1158,7 @@ impl InstanceCommon {
11571158

11581159
function_span
11591160
.record("timings.total_duration", tracing::field::debug(timings.total_duration))
1160-
.record("energy.used", tracing::field::debug(energy_used));
1161+
.record("energy.used", tracing::field::debug(execution_budget_used));
11611162

11621163
result
11631164
}
@@ -1413,7 +1414,7 @@ impl InstanceCommon {
14131414
let res = ViewCallResult {
14141415
outcome,
14151416
tx,
1416-
energy_used: result.stats.energy_used(),
1417+
execution_budget_used: result.stats.execution_budget_used(),
14171418
total_duration: result.stats.total_duration(),
14181419
abi_duration: result.stats.abi_duration(),
14191420
};
@@ -1465,7 +1466,7 @@ impl InstanceCommon {
14651466

14661467
out.tx = result.tx;
14671468
out.outcome = result.outcome;
1468-
out.energy_used += result.energy_used;
1469+
out.execution_budget_used += result.execution_budget_used;
14691470
out.total_duration += result.total_duration;
14701471
out.abi_duration += result.abi_duration;
14711472

@@ -1668,8 +1669,8 @@ impl VmMetrics {
16681669
self.reducer_plus_query_duration.clone().with_timer(start)
16691670
}
16701671

1671-
fn report_energy_used(&self, energy_used: FunctionBudget) {
1672-
self.reducer_fuel_used.inc_by(energy_used.get());
1672+
fn report_execution_budget_used(&self, execution_budget_used: FunctionBudget) {
1673+
self.reducer_fuel_used.inc_by(execution_budget_used.get());
16731674
}
16741675

16751676
fn report_total_duration(&self, duration: Duration) {
@@ -1682,10 +1683,10 @@ impl VmMetrics {
16821683

16831684
/// Reports some VM metrics.
16841685
fn report(&self, stats: &ExecutionStats) {
1685-
let energy_used = stats.energy.used();
1686+
let execution_budget_used = stats.energy.used();
16861687
let reducer_duration = stats.timings.total_duration;
16871688
let abi_time = stats.timings.wasm_instance_env_call_times.sum();
1688-
self.report_energy_used(energy_used);
1689+
self.report_execution_budget_used(execution_budget_used);
16891690
self.report_total_duration(reducer_duration);
16901691
self.report_abi_duration(abi_time);
16911692
}

crates/core/src/sql/execute.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ fn run_inner<I: WasmInstance>(
204204
},
205205
status: EventStatus::Committed(DatabaseUpdate::default()),
206206
reducer_return_value: None,
207-
execution_energy_used: FunctionBudget::ZERO,
207+
execution_budget_used: FunctionBudget::ZERO,
208208
host_execution_duration: Duration::ZERO,
209209
request_id: None,
210210
timer: None,

0 commit comments

Comments
 (0)