fix: comment logs that are spamming for bitcraft (#2887)

Author: Kasama

crates/core/src/host/wasm_common/module_host_actor.rs

@@ -7,7 +7,8 @@ use std::sync::Arc;
 use std::time::Duration;
 
 use super::instrumentation::CallTimes;
-use crate::database_logger::{self, SystemLogger};
+// use crate::database_logger;
+use crate::database_logger::SystemLogger;
 use crate::db::datastore::locking_tx_datastore::MutTxId;
 use crate::db::datastore::traits::{IsolationLevel, Program};
 use crate::db::db_metrics::DB_METRICS;
@@ -460,19 +461,19 @@ impl<T: WasmInstance> WasmModuleInstance<T> {
                 }
             }
             Ok(Err(errmsg)) => {
-                log::info!("reducer returned error: {errmsg}");
-
-                self.replica_context().logger.write(
-                    database_logger::LogLevel::Error,
-                    &database_logger::Record {
-                        ts: chrono::DateTime::from_timestamp_micros(timestamp.to_micros_since_unix_epoch()).unwrap(),
-                        target: Some(reducer_name),
-                        filename: None,
-                        line_number: None,
-                        message: &errmsg,
-                    },
-                    &(),
-                );
+                // log::info!("reducer returned error: {errmsg}");
+
+                // self.replica_context().logger.write(
+                //     database_logger::LogLevel::Error,
+                //     &database_logger::Record {
+                //         ts: chrono::DateTime::from_timestamp_micros(timestamp.to_micros_since_unix_epoch()).unwrap(),
+                //         target: Some(reducer_name),
+                //         filename: None,
+                //         line_number: None,
+                //         message: &errmsg,
+                //     },
+                //     &(),
+                // );
                 EventStatus::Failed(errmsg.into())
             }
             // We haven't actually committed yet - `commit_and_broadcast_event` will commit

crates/core/src/subscription/module_subscription_manager.rs

@@ -1521,8 +1521,8 @@ impl SendWorker {
 }
 
 fn send_to_client(client: &ClientConnectionSender, message: impl Into<SerializableMessage>) {
-    if let Err(e) = client.send_message(message) {
-        tracing::warn!(%client.id, "failed to send update message to client: {e}")
+    if let Err(_e) = client.send_message(message) {
+        //     tracing::warn!(%client.id, "failed to send update message to client: {e}")
     }
 }
 

smoketests/tests/client_connected_error_rejects_connection.py

@@ -36,7 +36,7 @@ def test_client_connected_error_rejects_connection(self):
             self.subscribe("select * from all_u8s", n = 0)()
 
         logs = self.logs(100)
-        self.assertIn('Rejecting connection from client', logs)
+        # self.assertIn('Rejecting connection from client', logs)
         self.assertNotIn('This should never be called, since we reject all connections!', logs)
 
 class ClientDisconnectedErrorStillDeletesStClient(Smoketest):

smoketests/tests/panic.py

@@ -47,4 +47,4 @@ def test_reducer_error_message(self):
         with self.assertRaises(Exception):
             self.call("fail")
 
-        self.assertIn("oopsie :(", self.logs(2))
+        # self.assertIn("oopsie :(", self.logs(2))