Skip to content

Commit 3226945

Browse files
committed
Small cleanup from #5271
1 parent d2142d6 commit 3226945

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1108,7 +1108,8 @@ jobs:
11081108
run: dotnet restore --configfile ../../../NuGet.Config blackholio.csproj
11091109

11101110
- name: Build Godot project
1111-
run: godot --headless --verbose --path demo/Blackholio/client-godot --build-solutions --quit
1111+
working-directory: demo/Blackholio/client-godot
1112+
run: godot --headless --verbose --build-solutions --quit
11121113

11131114
- name: Start SpacetimeDB
11141115
run: |
@@ -1122,7 +1123,8 @@ jobs:
11221123
bash ./publish.sh
11231124
11241125
- name: Run Godot tests
1125-
run: godot --headless --path demo/Blackholio/client-godot --scene res://tests/GodotPlayModeTests.tscn
1126+
working-directory: demo/Blackholio/client-godot
1127+
run: godot --headless --scene res://tests/GodotPlayModeTests.tscn
11261128

11271129
csharp-testsuite:
11281130
needs: [merge_queue_noop, lints]

crates/bindings-csharp/Runtime/TransactionalContextState.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private static void CommitMutTx()
9292
FFI.ErrnoHelpers.ThrowIfError(status);
9393
}
9494

95-
private void AbortMutTx()
95+
private static void AbortMutTx()
9696
{
9797
var status = FFI.procedure_abort_mut_tx();
9898
FFI.ErrnoHelpers.ThrowIfError(status);

sdks/csharp/src/SpacetimeDBClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System;
2-
using System.Collections;
32
using System.Collections.Concurrent;
43
using System.Collections.Generic;
54
using System.IO;
@@ -133,6 +132,8 @@ public abstract class DbConnectionBase<DbConnection, Tables, Reducer> : IDbConne
133132
where DbConnection : DbConnectionBase<DbConnection, Tables, Reducer>, new()
134133
where Tables : RemoteTablesBase
135134
{
135+
internal const bool IsTesting = false;
136+
136137
public static DbConnectionBuilder<DbConnection> Builder() => new();
137138

138139
internal event Action<Identity, string>? onConnect;
@@ -281,7 +282,6 @@ internal struct ParsedMessage
281282
private readonly BlockingCollection<ParsedMessage> _applyQueue =
282283
new(new ConcurrentQueue<ParsedMessage>());
283284

284-
internal static bool IsTesting;
285285
internal bool HasMessageToApply => _applyQueue.Count > 0;
286286

287287
private readonly CancellationTokenSource _parseCancellationTokenSource = new();

0 commit comments

Comments
 (0)