Log instead of panicking when missing a row from st_client (#2722)

Author: gefjon

crates/core/src/db/datastore/locking_tx_datastore/mut_tx.rs

@@ -1244,21 +1244,30 @@ impl MutTxId {
         self.insert_via_serialize_bsatn(ST_CLIENT_ID, row).map(|_| ())
     }
 
-    pub(crate) fn delete_st_client(&mut self, identity: Identity, connection_id: ConnectionId) -> Result<()> {
+    pub(crate) fn delete_st_client(
+        &mut self,
+        identity: Identity,
+        connection_id: ConnectionId,
+        database_identity: Identity,
+    ) -> Result<()> {
         let row = &StClientRow {
             identity: identity.into(),
             connection_id: connection_id.into(),
         };
-        let ptr = self
+        if let Some(ptr) = self
             .iter_by_col_eq(
                 ST_CLIENT_ID,
                 col_list![StClientFields::Identity, StClientFields::ConnectionId],
                 &AlgebraicValue::product(row),
             )?
             .next()
-            .expect("the client should be connected")
-            .pointer();
-        self.delete(ST_CLIENT_ID, ptr).map(drop)
+            .map(|row| row.pointer())
+        {
+            self.delete(ST_CLIENT_ID, ptr).map(drop)
+        } else {
+            log::error!("[{database_identity}]: delete_st_client: attempting to delete client ({identity}, {connection_id}), but no st_client row for that client is resident");
+            Ok(())
+        }
     }
 
     pub(crate) fn insert_via_serialize_bsatn<'a, T: Serialize>(

crates/core/src/host/module_host.rs

@@ -677,7 +677,7 @@ impl ModuleHost {
                 .replica_ctx()
                 .relational_db
                 .with_auto_commit(workload, |mut_tx| {
-                    mut_tx.delete_st_client(caller_identity, caller_connection_id)
+                    mut_tx.delete_st_client(caller_identity, caller_connection_id, self.info.database_identity)
                 })
                 .inspect_err(|e| {
                     log::error!(

crates/core/src/host/wasm_common/module_host_actor.rs

@@ -558,7 +558,9 @@ impl<T: WasmInstance> WasmModuleInstance<T> {
             Ok(Ok(())) => {
                 let res = match reducer_def.lifecycle {
                     Some(Lifecycle::OnConnect) => tx.insert_st_client(caller_identity, caller_connection_id),
-                    Some(Lifecycle::OnDisconnect) => tx.delete_st_client(caller_identity, caller_connection_id),
+                    Some(Lifecycle::OnDisconnect) => {
+                        tx.delete_st_client(caller_identity, caller_connection_id, database_identity)
+                    }
                     _ => Ok(()),
                 };
                 match res {