Merge remote-tracking branch 'origin/kim/ci/skip-unity-external' into test-skip-unity-external

Author: kim

.github/workflows/csharp-test.yml

@@ -142,4 +142,4 @@ jobs:
           UNITY_SERIAL: ${{ secrets.UNITY_SERIAL }}
         # Skip if this is an external contribution.
         # The license secrets will be empty, so the step would fail anyway.
-        if: !github.event.pull_request.head.repo.fork
+        if: ${{ !github.event.pull_request.head.repo.fork }}

Cargo.lock

@@ -257,7 +257,7 @@ syntect = { version = "5.0.0", default-features = false, features = ["default-fa
 tabled = "0.14.0"
 tar = "0.4"
 tempdir = "0.3.7"
-tempfile = "3.8"
+tempfile = "3.20"
 termcolor = "1.2.0"
 thin-vec = "0.2.13"
 thiserror = "1.0.37"
@@ -293,7 +293,7 @@ windows-sys = "0.59"
 xdg = "2.5"
 tikv-jemallocator = { version = "0.6.0", features = ["profiling", "stats"] }
 tikv-jemalloc-ctl = { version = "0.6.0", features = ["stats"] }
-jemalloc_pprof = { version = "0.7", features = ["symbolize", "flamegraph"] }
+jemalloc_pprof = { version = "0.8", features = ["symbolize", "flamegraph"] }
 zstd-framed = { version = "0.1.1", features = ["tokio"] }
 
 # Vendor the openssl we rely on, rather than depend on a

Cargo.toml

@@ -1708,7 +1708,7 @@ pub mod tests_utils {
     impl TempReplicaDir {
         pub fn new() -> io::Result<Self> {
             let dir = TempDir::with_prefix("stdb_test")?;
-            Ok(Self(ReplicaDir::from_path_unchecked(dir.into_path())))
+            Ok(Self(ReplicaDir::from_path_unchecked(dir.keep())))
         }
     }
     impl Deref for TempReplicaDir {

crates/core/src/db/relational_db.rs

@@ -527,7 +527,7 @@ mod test {
     /// An `InstanceEnv` requires a `DatabaseLogger`
     fn temp_logger() -> Result<DatabaseLogger> {
         let temp = TempDir::new()?;
-        let path = ModuleLogsDir::from_path_unchecked(temp.into_path());
+        let path = ModuleLogsDir::from_path_unchecked(temp.keep());
         let path = path.today();
         Ok(DatabaseLogger::open(path))
     }

crates/core/src/host/instance_env.rs

@@ -22,7 +22,7 @@ pub fn ensure_standalone_process() -> &'static SpacetimePaths {
             // TODO: This leaks the tempdir.
             //       We need the tempdir to live for the duration of the process,
             //       and all the options for post-`main` cleanup seem sketchy.
-            .into_path();
+            .keep();
         SpacetimePaths::from_root_dir(&RootDir(dir))
     });