Skip to content

Commit 4f95859

Browse files
Drop tps threshold for rust keynote-2 ci check (#5159)
# Description of Changes The keynote benchmark check has had a couple spurious failures in CI recently, namely for the rust module. I set a higher TPS threshold for rust than I did for typescript since rust is a bit faster, but it looks like the threshold I set is within the margin of error, so this change drops it to 275K - exactly what it is for typescript. A failure now almost certainly represents a real performance regression and requires deeper investigation. # API and ABI breaking changes N/A # Expected complexity level and risk 0 (one liner) # Testing Should have no more spurious failures for this CI job.
1 parent fa5fa7c commit 4f95859

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/ci/src/keynote_bench.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const BENCHMARK_MODULES: &[BenchmarkModule] = &[
3333
BenchmarkModule {
3434
label: "Rust",
3535
module_dir: "templates/keynote-2/rust_module",
36-
min_tps: 300_000.0,
36+
min_tps: 275_000.0,
3737
},
3838
];
3939

0 commit comments

Comments
 (0)