Small codegen fixes to treat unknown request ids as a protocol violation

JasonAtClockwork · JasonAtClockwork · commit 5790ba469d5c · 2026-03-05T15:38:30.000-08:00
diff --git a/crates/codegen/src/unrealcpp.rs b/crates/codegen/src/unrealcpp.rs
@@ -3514,8 +3514,7 @@ fn generate_client_implementation(
         output,
         "        const FString ErrorMessage = FString::Printf(TEXT(\"Reducer result for unknown request_id %u\"), Event.RequestId);"
     );
-    writeln!(output, "        UE_LOG(LogTemp, Error, TEXT(\"%s\"), *ErrorMessage);");
-    writeln!(output, "        ReducerEventFailed(Event, ErrorMessage);");
+    writeln!(output, "        HandleProtocolViolation(ErrorMessage);");
     writeln!(output, "        return;");
     writeln!(output, "    }}");
     writeln!(output);
@@ -3876,6 +3875,7 @@ fn generate_client_implementation(
         "void U{module_prefix}DbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)"
     );
     writeln!(output, "{{");
+    writeln!(output, "\tPendingTypedReducers.Empty();");
     writeln!(output, "\tif (OnDisconnectDelegate.IsBound())");
     writeln!(output, "\t{{");
     writeln!(output, "\t\tOnDisconnectDelegate.Execute(this, Error);");
@@ -3911,13 +3911,10 @@ fn generate_client_implementation(
     writeln!(output, "        {{");
     writeln!(
         output,
-        "            UE_LOG(LogTemp, Warning, TEXT(\"Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event\"), ReducerEvent.RequestId);"
+        "            const FString ErrorMessage = FString::Printf(TEXT(\"Reducer result for unknown request_id %u\"), ReducerEvent.RequestId);"
     );
-    writeln!(
-        output,
-        "            BaseEvent = F{module_name_pascal}Event::UnknownTransaction(FSpacetimeDBUnit());"
-    );
-    writeln!(output, "            break;");
+    writeln!(output, "            HandleProtocolViolation(ErrorMessage);");
+    writeln!(output, "            return;");
     writeln!(output, "        }}");
     writeln!(
         output,
diff --git a/sdks/unreal/examples/QuickstartChat/Source/QuickstartChat/Private/ModuleBindings/SpacetimeDBClient.g.cpp b/sdks/unreal/examples/QuickstartChat/Source/QuickstartChat/Private/ModuleBindings/SpacetimeDBClient.g.cpp
@@ -226,8 +226,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)
     if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))
     {
         const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);
-        UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);
-        ReducerEventFailed(Event, ErrorMessage);
+        HandleProtocolViolation(ErrorMessage);
         return;
     }
 
@@ -431,6 +430,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti
 }
 void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)
 {
+	PendingTypedReducers.Empty();
 	if (OnDisconnectDelegate.IsBound())
 	{
 		OnDisconnectDelegate.Execute(this, Error);
@@ -451,9 +451,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime
         FReducer Reducer;
         if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))
         {
-            UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);
-            BaseEvent = FQuickstartChatEvent::UnknownTransaction(FSpacetimeDBUnit());
-            break;
+            const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);
+            HandleProtocolViolation(ErrorMessage);
+            return;
         }
         BaseEvent = FQuickstartChatEvent::Reducer(Reducer);
         break;
diff --git a/sdks/unreal/tests/TestClient/Source/TestClient/Private/ModuleBindings/SpacetimeDBClient.g.cpp b/sdks/unreal/tests/TestClient/Source/TestClient/Private/ModuleBindings/SpacetimeDBClient.g.cpp
@@ -9662,8 +9662,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)
     if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))
     {
         const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);
-        UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);
-        ReducerEventFailed(Event, ErrorMessage);
+        HandleProtocolViolation(ErrorMessage);
         return;
     }
 
@@ -11037,6 +11036,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti
 }
 void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)
 {
+	PendingTypedReducers.Empty();
 	if (OnDisconnectDelegate.IsBound())
 	{
 		OnDisconnectDelegate.Execute(this, Error);
@@ -11057,9 +11057,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime
         FReducer Reducer;
         if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))
         {
-            UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);
-            BaseEvent = FTestClientEvent::UnknownTransaction(FSpacetimeDBUnit());
-            break;
+            const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);
+            HandleProtocolViolation(ErrorMessage);
+            return;
         }
         BaseEvent = FTestClientEvent::Reducer(Reducer);
         break;
diff --git a/sdks/unreal/tests/TestProcClient/Source/TestProcClient/Private/ModuleBindings/SpacetimeDBClient.g.cpp b/sdks/unreal/tests/TestProcClient/Source/TestProcClient/Private/ModuleBindings/SpacetimeDBClient.g.cpp
@@ -474,8 +474,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)
     if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))
     {
         const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);
-        UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);
-        ReducerEventFailed(Event, ErrorMessage);
+        HandleProtocolViolation(ErrorMessage);
         return;
     }
 
@@ -673,6 +672,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti
 }
 void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)
 {
+	PendingTypedReducers.Empty();
 	if (OnDisconnectDelegate.IsBound())
 	{
 		OnDisconnectDelegate.Execute(this, Error);
@@ -693,9 +693,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime
         FReducer Reducer;
         if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))
         {
-            UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);
-            BaseEvent = FTestProcClientEvent::UnknownTransaction(FSpacetimeDBUnit());
-            break;
+            const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);
+            HandleProtocolViolation(ErrorMessage);
+            return;
         }
         BaseEvent = FTestProcClientEvent::Reducer(Reducer);
         break;

Original file line number	Diff line number	Diff line change
`@@ -226,8 +226,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)`
`226`	`226`	`if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))`
`227`	`227`	`{`
`228`	`228`	`const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);`
`229`		`- UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);`
`230`		`- ReducerEventFailed(Event, ErrorMessage);`
	`229`	`+ HandleProtocolViolation(ErrorMessage);`
`231`	`230`	`return;`
`232`	`231`	`}`
`233`	`232`
`@@ -431,6 +430,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti`
`431`	`430`	`}`
`432`	`431`	`void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)`
`433`	`432`	`{`
	`433`	`+ PendingTypedReducers.Empty();`
`434`	`434`	`if (OnDisconnectDelegate.IsBound())`
`435`	`435`	`{`
`436`	`436`	`OnDisconnectDelegate.Execute(this, Error);`
`@@ -451,9 +451,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime`
`451`	`451`	`FReducer Reducer;`
`452`	`452`	`if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))`
`453`	`453`	`{`
`454`		`- UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);`
`455`		`- BaseEvent = FQuickstartChatEvent::UnknownTransaction(FSpacetimeDBUnit());`
`456`		`- break;`
	`454`	`+ const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);`
	`455`	`+ HandleProtocolViolation(ErrorMessage);`
	`456`	`+ return;`
`457`	`457`	`}`
`458`	`458`	`BaseEvent = FQuickstartChatEvent::Reducer(Reducer);`
`459`	`459`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -9662,8 +9662,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)`
`9662`	`9662`	`if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))`
`9663`	`9663`	`{`
`9664`	`9664`	`const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);`
`9665`		`- UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);`
`9666`		`- ReducerEventFailed(Event, ErrorMessage);`
	`9665`	`+ HandleProtocolViolation(ErrorMessage);`
`9667`	`9666`	`return;`
`9668`	`9667`	`}`
`9669`	`9668`
`@@ -11037,6 +11036,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti`
`11037`	`11036`	`}`
`11038`	`11037`	`void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)`
`11039`	`11038`	`{`
	`11039`	`+ PendingTypedReducers.Empty();`
`11040`	`11040`	`if (OnDisconnectDelegate.IsBound())`
`11041`	`11041`	`{`
`11042`	`11042`	`OnDisconnectDelegate.Execute(this, Error);`
`@@ -11057,9 +11057,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime`
`11057`	`11057`	`FReducer Reducer;`
`11058`	`11058`	`if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))`
`11059`	`11059`	`{`
`11060`		`- UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);`
`11061`		`- BaseEvent = FTestClientEvent::UnknownTransaction(FSpacetimeDBUnit());`
`11062`		`- break;`
	`11060`	`+ const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);`
	`11061`	`+ HandleProtocolViolation(ErrorMessage);`
	`11062`	`+ return;`
`11063`	`11063`	`}`
`11064`	`11064`	`BaseEvent = FTestClientEvent::Reducer(Reducer);`
`11065`	`11065`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -474,8 +474,7 @@ void UDbConnection::ReducerEvent(const FReducerEvent& Event)`
`474`	`474`	`if (!TryTakePendingTypedReducer(Event.RequestId, DecodedReducer))`
`475`	`475`	`{`
`476`	`476`	`const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), Event.RequestId);`
`477`		`- UE_LOG(LogTemp, Error, TEXT("%s"), *ErrorMessage);`
`478`		`- ReducerEventFailed(Event, ErrorMessage);`
	`477`	`+ HandleProtocolViolation(ErrorMessage);`
`479`	`478`	`return;`
`480`	`479`	`}`
`481`	`480`
`@@ -673,6 +672,7 @@ void UDbConnection::ForwardOnConnect(UDbConnectionBase* BaseConnection, FSpaceti`
`673`	`672`	`}`
`674`	`673`	`void UDbConnection::ForwardOnDisconnect(UDbConnectionBase* BaseConnection, const FString& Error)`
`675`	`674`	`{`
	`675`	`+ PendingTypedReducers.Empty();`
`676`	`676`	`if (OnDisconnectDelegate.IsBound())`
`677`	`677`	`{`
`678`	`678`	`OnDisconnectDelegate.Execute(this, Error);`
`@@ -693,9 +693,9 @@ void UDbConnection::DbUpdate(const FDatabaseUpdateType& Update, const FSpacetime`
`693`	`693`	`FReducer Reducer;`
`694`	`694`	`if (!TryGetPendingTypedReducer(ReducerEvent.RequestId, Reducer))`
`695`	`695`	`{`
`696`		`- UE_LOG(LogTemp, Warning, TEXT("Missing typed reducer for request_id %u while building table-update event context; using UnknownTransaction event"), ReducerEvent.RequestId);`
`697`		`- BaseEvent = FTestProcClientEvent::UnknownTransaction(FSpacetimeDBUnit());`
`698`		`- break;`
	`696`	`+ const FString ErrorMessage = FString::Printf(TEXT("Reducer result for unknown request_id %u"), ReducerEvent.RequestId);`
	`697`	`+ HandleProtocolViolation(ErrorMessage);`
	`698`	`+ return;`
`699`	`699`	`}`
`700`	`700`	`BaseEvent = FTestProcClientEvent::Reducer(Reducer);`
`701`	`701`	`break;`