Merge remote-tracking branch 'origin/master' into jdetter/move-docs-to-new-runner

Author: bfops

.github/workflows/attach-artifacts.yml

@@ -0,0 +1,67 @@
+name: Attach client binaries to release
+
+on:
+  workflow_dispatch:
+    inputs:
+      release_tag:
+        description: "Release tag (e.g. v1.9.0)"
+        required: true
+
+jobs:
+  upload-assets:
+    runs-on: spacetimedb-new-runner
+    container:
+      image: localhost:5000/spacetimedb-ci:latest
+      options: >-
+        --privileged
+    permissions:
+      contents: write  # needed to modify releases
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Download artifacts from private base URL
+        env:
+          RELEASE_TAG: ${{ github.event.inputs.release_tag }}
+          BASE_URL: ${{ secrets.ARTIFACT_BASE_URL }}
+        run: |
+          set -euo pipefail
+
+          FULL_URL="$BASE_URL/$RELEASE_TAG"
+
+          mkdir -p artifacts
+          cd artifacts
+
+          download() {
+            local filename="$1"
+            if ! wget -q "${FULL_URL}/${filename}" -O "${filename}"; then
+              echo "Failed to download ${filename}"
+              exit 1
+            fi
+          }
+
+          download "spacetime-aarch64-apple-darwin.tar.gz"
+          download "spacetime-aarch64-unknown-linux-gnu.tar.gz"
+          download "spacetime-x86_64-apple-darwin.tar.gz"
+          download "spacetime-x86_64-pc-windows-msvc.zip"
+          download "spacetime-x86_64-unknown-linux-gnu.tar.gz"
+          download "spacetimedb-update-aarch64-apple-darwin"
+          download "spacetimedb-update-aarch64-unknown-linux-gnu"
+          download "spacetimedb-update-x86_64-apple-darwin"
+          download "spacetimedb-update-x86_64-pc-windows-msvc.exe"
+          download "spacetimedb-update-x86_64-unknown-linux-gnu"
+
+      - name: Upload artifacts to GitHub Release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          RELEASE_TAG: ${{ github.event.inputs.release_tag }}
+        run: |
+          set -euo pipefail
+
+          cd artifacts
+
+          gh release upload "$RELEASE_TAG" ./* \
+            --repo "$GITHUB_REPOSITORY" \
+            --clobber
+

.github/workflows/ci.yml

@@ -317,16 +317,21 @@ jobs:
           fi
 
   update:
-    name: Test spacetimedb-update flow
+    name: Test spacetimedb-update flow (${{ matrix.target }})
     permissions: read-all
     strategy:
       matrix:
         include:
-          - { target: x86_64-unknown-linux-gnu, runner: spacetimedb-runner }
+          - runner: spacetimedb-new-runner
+            target: x86_64-unknown-linux-gnu
+            container:
+              image: localhost:5000/spacetimedb-ci:latest
+              options: --privileged
           - { target: aarch64-unknown-linux-gnu, runner: arm-runner }
           - { target: aarch64-apple-darwin, runner: macos-latest }
           - { target: x86_64-pc-windows-msvc, runner: windows-latest }
     runs-on: ${{ matrix.runner }}
+    container: ${{ matrix.container }}
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -362,8 +367,11 @@ jobs:
     # This can't go on e.g. ubuntu-latest because that runner runs out of disk space. ChatGPT suggested that the general solution tends to be to use
     # a custom runner.
     runs-on: spacetimedb-new-runner
+    # Disable the tests because they are very flaky at the moment.
+    # TODO: Remove this line and re-enable the `if` line just below here.
+    if: false
     # Skip if this is an external contribution. GitHub secrets will be empty, so the step would fail anyway.
-    if: ${{ github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork }}
+    # if: ${{ github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork }}
     container:
       image: ghcr.io/epicgames/unreal-engine:dev-5.6
       credentials:
@@ -509,7 +517,7 @@ jobs:
           cargo run --features markdown-docs -p spacetimedb-cli > docs/docs/cli-reference.md
           pnpm format
           git status
-          if git diff --exit-code HEAD; then
+          if git diff --exit-code HEAD -- docs/docs/cli-reference.md; then
             echo "No docs changes detected"
           else
             echo "It looks like the CLI docs have changed:"

.github/workflows/discord-posts.yml

@@ -36,7 +36,7 @@ jobs:
               --json 'workflow,state,name' |
               jq '.[]
                 | select(.workflow != "Discord notifications")
-                | select(.state != "SUCCESS" and .state != "NEUTRAL")
+                | select(.state != "SUCCESS" and .state != "NEUTRAL" and .state != "SKIPPED")
               ' |
               jq -r '"\(.workflow) / \(.name): \(.state)"'
           )"
@@ -60,11 +60,11 @@ jobs:
             message+=$'\n'
             # This uses special Discord syntax for pinging a particular role.
             # Note the '&' - this is the difference between pinging a *role* and pinging a *person*.
-            message+=" (cc <@&${MENTION_ON_FAILURE}>"
             if [[ -n "${author_discord_id}" ]]; then
-              message+=" <@${author_discord_id}>"
+              message+="<@${author_discord_id}> please investigate these failures."
             fi
-            message+=")"
+            message+=$'\n'
+            message+="(cc <@&${MENTION_ON_FAILURE}> - Releases may be affected)"
           fi
           # Use `jq` to construct the json data blob in the format required by the webhook.
           data="$(jq --null-input --arg msg "$message" '.content=$msg')"

.github/workflows/package.yml

@@ -14,7 +14,13 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { name: x86_64 Linux, target: x86_64-unknown-linux-gnu, runner: ubuntu-latest }
+          - name: x86_64 Linux
+            target: x86_64-unknown-linux-gnu
+            runner: spacetimedb-new-runner
+            container:
+              image: localhost:5000/spacetimedb-ci:latest
+              options: >-
+                --privileged
           - { name: aarch64 Linux, target: aarch64-unknown-linux-gnu, runner: arm-runner }
           # Disabled because musl builds weren't working and we didn't want to investigate. See https://github.com/clockworklabs/SpacetimeDB/pull/2964.
           # - { name: x86_64 Linux musl, target: x86_64-unknown-linux-musl, runner: bare-metal, container: alpine }

.github/workflows/upgrade-version-check.yml

@@ -8,7 +8,10 @@ permissions: read-all
 
 jobs:
   version_upgrade_check:
-    runs-on: spacetimedb-runner
+    runs-on: spacetimedb-new-runner
+    container:
+      image: localhost:5000/spacetimedb-ci:latest
+      options: --privileged
     steps:
       - name: Checkout
         uses: actions/checkout@v3