Skip to content

Commit 59b5d49

Browse files
Fix Internal Tests paths filter checkout (#5295)
## What changed Adds an explicit checkout step before `dorny/paths-filter` in the Internal Tests workflow. ## Why `dorny/paths-filter@v3` needs a git working tree for `push` events. The Internal Tests workflow ran it before any checkout, so every `push` run on `master` failed immediately in `Detect non-docs changes` with: ```text fatal: not a git repository (or any of the parent directories): .git ``` This only showed up consistently on `master` because those runs are `push` events. On `pull_request` events, `dorny/paths-filter` can use the GitHub pull request files API with the PR number, so it does not need a local checkout for the same file detection path. Adding checkout gives the action a repository when it handles `push` events, while leaving PR behavior unchanged. ## Testing - `git diff --check` - PR #5295 `Internal Tests` job completed `Checkout` and `Detect non-docs changes` successfully, then moved on to private dispatch/wait. --------- Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
1 parent fc2f761 commit 59b5d49

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/internal-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ jobs:
3030
TARGET_OWNER: clockworklabs
3131
TARGET_REPO: SpacetimeDBPrivate
3232
steps:
33+
# Required for the path filter check below on non-PR commits (e.g. `master`)
34+
- name: Checkout
35+
uses: actions/checkout@v4
36+
3337
# Skip the private dispatch entirely when only `docs/` is touched. The job
3438
# itself still completes successfully so required-status-check gating is
3539
# satisfied without spending private-runner time on a docs-only change.

0 commit comments

Comments
 (0)