Skip to content

Commit 6b01a1a

Browse files
committed
[bfops/wasm-test]: fix test?
1 parent 7757559 commit 6b01a1a

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

sdks/rust/tests/test-client/src/module_bindings/mod.rs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdks/rust/tests/test-client/src/test_handlers.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2415,10 +2415,7 @@ async fn test_intra_query_bag_semantics_for_join(db_name: &str) {
24152415
let sub_applied_nothing_result = test_counter.add_test("on_subscription_applied_nothing");
24162416
let mut pk_u32_on_delete_result = Some(test_counter.add_test("pk_u32_on_delete"));
24172417

2418-
// This test drives the whole subscription sequence from async callbacks.
2419-
// Keep the connection alive until those callbacks finish so we don't tear
2420-
// down the sender loop before the queued subscribe message is flushed.
2421-
let conn = connect_then(db_name, &test_counter, {
2418+
connect_then(db_name, &test_counter, {
24222419
move |ctx| {
24232420
subscribe_these_then(
24242421
ctx,
@@ -2493,8 +2490,6 @@ async fn test_intra_query_bag_semantics_for_join(db_name: &str) {
24932490
}
24942491
})
24952492
.await;
2496-
test_counter.wait_for_all().await;
2497-
drop(conn);
24982493
}
24992494

25002495
/// Test that several clients subscribing to the same query and using the same protocol (bsatn)

sdks/rust/tests/test.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,12 @@ macro_rules! declare_tests_with_suffix {
353353
make_test("test-lhs-join-update-disjoint-queries").run()
354354
}
355355

356+
// The Rust client variant of this test is currently under-synchronized:
357+
// it returns basically instantly after starting the connection.
358+
// It's also somewhat broken due to casing issues.
359+
// Re-enable this test once it is fixed and properly waiting for its results.
356360
#[test]
361+
#[ignore = "Flaky until test-client retains ignored connections or this test owns its connection lifetime"]
357362
fn test_intra_query_bag_semantics_for_join() {
358363
make_test("test-intra-query-bag-semantics-for-join").run()
359364
}

0 commit comments

Comments
 (0)