Bump rust-toolchain to rust 1.88 (#2749)

Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>

Author: coolreader18

.github/workflows/benchmarks.yml

@@ -183,7 +183,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20 # on a successful run, runs in 8 minutes
     container:
-      image: rust:1.83.0
+      image: rust:1.88.0
       options: --privileged
     # filter for a comment containing 'benchmarks please'
     if: ${{ github.event_name != 'issue_comment' || (github.event.issue.pull_request && contains(github.event.comment.body, 'benchmarks please')) }}

Cargo.toml

@@ -91,7 +91,7 @@ debug = true
 version = "1.2.0"
 edition = "2021"
 # update rust-toolchain.toml too!
-rust-version = "1.84.0"
+rust-version = "1.88.0"
 
 [workspace.dependencies]
 spacetimedb = { path = "crates/bindings", version = "1.2.0" }
@@ -326,3 +326,10 @@ features = [
   "broadcast",
   "ondemand",
 ]
+
+[workspace.lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tokio_unstable)'] }
+
+[workspace.lints.clippy]
+# FIXME: we should work on this lint incrementally
+result_large_err = "allow"

crates/auth/Cargo.toml

@@ -16,3 +16,6 @@ jsonwebtoken.workspace = true
 
 [dev-dependencies]
 serde_json.workspace = true
+
+[lints]
+workspace = true

crates/bench/Cargo.toml

@@ -90,3 +90,6 @@ tikv-jemalloc-ctl = { workspace = true }
 iai-callgrind = { git = "https://github.com/clockworklabs/iai-callgrind.git", branch = "main" }
 iai-callgrind-runner = { git = "https://github.com/clockworklabs/iai-callgrind.git", branch = "main" }
 iai-callgrind-macros = { git = "https://github.com/clockworklabs/iai-callgrind.git", branch = "main" }
+
+[lints]
+workspace = true

crates/bench/Dockerfile

@@ -3,7 +3,7 @@
 # See the README for commands to run.
 
 # sync with: ../../rust-toolchain.toml
-FROM rust:1.84.0
+FROM rust:1.88.0
 
 RUN apt-get update && \
     apt-get install -y valgrind bash && \

crates/bench/src/bin/summarize.rs

@@ -99,7 +99,7 @@ mod criterion {
 
     /// `"{crit_dir}/"{name}.json"`
     fn packed_baseline_json_path(crit_dir: &Path, name: &str) -> PathBuf {
-        crit_dir.join(format!("{}.json", name))
+        crit_dir.join(format!("{name}.json"))
     }
 
     lazy_static::lazy_static! {
@@ -392,7 +392,7 @@ mod callgrind {
     }
 
     fn packed_json_path(iai_callgrind_dir: &Path, name: &str) -> PathBuf {
-        iai_callgrind_dir.join(format!("{}.json", name))
+        iai_callgrind_dir.join(format!("{name}.json"))
     }
 
     fn get_iai_callgrind_dir(target_dir: &Path) -> PathBuf {

crates/bench/src/spacetime_module.rs

@@ -70,10 +70,10 @@ impl<L: ModuleLanguage> BenchDatabase for SpacetimeModule<L> {
         });
 
         for table in module.client.module.info.module_def.tables() {
-            log::trace!("SPACETIME_MODULE: LOADED TABLE: {:?}", table);
+            log::trace!("SPACETIME_MODULE: LOADED TABLE: {table:?}");
         }
         for reducer in module.client.module.info.module_def.reducers() {
-            log::trace!("SPACETIME_MODULE: LOADED REDUCER: {:?}", reducer);
+            log::trace!("SPACETIME_MODULE: LOADED REDUCER: {reducer:?}");
         }
         Ok(SpacetimeModule {
             runtime,

crates/bindings-macro/Cargo.toml

@@ -19,3 +19,6 @@ proc-macro2.workspace = true
 quote.workspace = true
 syn.workspace = true
 heck.workspace = true
+
+[lints]
+workspace = true

crates/bindings-macro/src/table.rs

@@ -800,7 +800,7 @@ pub(crate) fn table_impl(mut args: TableArgs, item: &syn::DeriveInput) -> syn::R
     if std::env::var("PROC_MACRO_DEBUG").is_ok() {
         {
             #![allow(clippy::disallowed_macros)]
-            println!("{}", emission);
+            println!("{emission}");
         }
     }
 

crates/bindings-macro/src/util.rs

@@ -76,7 +76,7 @@ pub(crate) fn one_of(options: &[crate::sym::Symbol]) -> String {
         }
         _ => {
             let join = options.join("`, `");
-            format!("expected one of: `{}`", join)
+            format!("expected one of: `{join}`")
         }
     }
 }