Misc cleanups in tools/upgrade-version (#3370)

# Description of Changes

* Make sure the user provides at least one of `--rust-and-cli`,
`--typescript`, or `--csharp`, since providing none of them is a no-op
as of #3308
* Do a semver-parsing of the arg before doing anything, and use that
parsed version everywhere
* Consolidate some version strings that we were computing in a few
places

# API and ABI breaking changes

None

# Expected complexity level and risk

1

# Testing

- [x] Running `cargo bump-versions 1.5.0 --typescript --rust-and-cli
--csharp` only shows a diff in the change dates

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>

Author: bfops

tools/upgrade-version/src/main.rs

@@ -1,7 +1,7 @@
 #![allow(clippy::disallowed_macros)]
 
 use chrono::{Datelike, Local};
-use clap::{Arg, Command};
+use clap::{Arg, ArgGroup, Command};
 use duct::cmd;
 use regex::Regex;
 use semver::Version;
@@ -90,9 +90,26 @@ fn main() -> anyhow::Result<()> {
                 .action(clap::ArgAction::SetTrue)
                 .help("Also bump versions in C# SDK and templates"),
         )
+        .arg(
+            Arg::new("all")
+                .long("all")
+                .action(clap::ArgAction::SetTrue)
+                .help("Update all targets (equivalent to --typescript --rust-and-cli --csharp)")
+                .conflicts_with_all(["typescript", "rust-and-cli", "csharp"]),
+        )
+        .group(
+            ArgGroup::new("update-targets")
+                .args(["all", "typescript", "rust-and-cli", "csharp"])
+                .required(true)
+                .multiple(true),
+        )
         .get_matches();
 
-    let version = matches.get_one::<String>("upgrade_version").unwrap();
+    let unparsed_version_arg = matches.get_one::<String>("upgrade_version").unwrap();
+    let semver = Version::parse(unparsed_version_arg).expect("Invalid semver provided to upgrade-version");
+    let full_version = format!("{}.{}.{}", semver.major, semver.minor, semver.patch);
+    let wildcard_patch = format!("{}.{}.*", semver.major, semver.minor);
+
     if let Some(path) = matches.get_one::<PathBuf>("spacetime-path") {
         env::set_current_dir(path).ok();
     }
@@ -103,14 +120,14 @@ fn main() -> anyhow::Result<()> {
         anyhow::bail!("You must execute this binary from inside of the SpacetimeDB directory, or use --spacetime-path");
     }
 
-    if matches.get_flag("rust-and-cli") {
+    if matches.get_flag("rust-and-cli") || matches.get_flag("all") {
         // Use `=` for dependency versions, to avoid issues where Cargo automatically rolls forward to later minor versions.
         // See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#default-requirements.
-        let dep_version = format!("={version}");
+        let dep_version = format!("={full_version}");
 
         // root Cargo.toml
         edit_toml("Cargo.toml", |doc| {
-            doc["workspace"]["package"]["version"] = toml_edit::value(version);
+            doc["workspace"]["package"]["version"] = toml_edit::value(full_version.clone());
             for (key, dep) in doc["workspace"]["dependencies"]
                 .as_table_like_mut()
                 .expect("workspace.dependencies is not a table")
@@ -128,26 +145,19 @@ fn main() -> anyhow::Result<()> {
             //
             // Note: This is meaningfully different than setting just major.minor.
             // See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#default-requirements.
-            let v = Version::parse(version).expect("Invalid semver provided to upgrade-version");
-            let major_minor = format!("{}.{}.*", v.major, v.minor);
-            doc["dependencies"]["spacetimedb"] = toml_edit::value(major_minor);
+            doc["dependencies"]["spacetimedb"] = toml_edit::value(wildcard_patch.clone());
         })?;
 
-        process_license_file("LICENSE.txt", version);
-        process_license_file("licenses/BSL.txt", version);
+        process_license_file("LICENSE.txt", &full_version);
+        process_license_file("licenses/BSL.txt", &full_version);
         cmd!("cargo", "check").run().expect("Cargo check failed!");
     }
 
-    if matches.get_flag("typescript") {
-        rewrite_json_version_inplace("crates/bindings-typescript/package.json", version)?;
+    if matches.get_flag("typescript") || matches.get_flag("all") {
+        rewrite_json_version_inplace("crates/bindings-typescript/package.json", &full_version)?;
     }
 
-    if matches.get_flag("csharp") {
-        // Compute various version forms
-        let v = Version::parse(version).expect("Invalid semver provided to upgrade-version");
-        let wildcard_patch = format!("{}.{}.*", v.major, v.minor);
-        let assembly_version = format!("{}.{}.{}", v.major, v.minor, v.patch);
-
+    if matches.get_flag("csharp") || matches.get_flag("all") {
         // Helpers for XML edits
         fn rewrite_xml_tag_value(path: &str, tag: &str, new_value: &str) -> anyhow::Result<()> {
             let contents = fs::read_to_string(path)?;
@@ -196,13 +206,13 @@ fn main() -> anyhow::Result<()> {
 
         // 1) Client SDK csproj
         let client_sdk = "sdks/csharp/SpacetimeDB.ClientSDK.csproj";
-        rewrite_xml_tag_value(client_sdk, "Version", version)?;
-        rewrite_xml_tag_value(client_sdk, "AssemblyVersion", &assembly_version)?;
+        rewrite_xml_tag_value(client_sdk, "Version", &full_version)?;
+        rewrite_xml_tag_value(client_sdk, "AssemblyVersion", &full_version)?;
         // Update SpacetimeDB.BSATN.Runtime dependency to major.minor.*
         rewrite_csproj_package_ref_version(client_sdk, "SpacetimeDB.BSATN.Runtime", &wildcard_patch)?;
 
         // Also bump the C# SDK package.json version (preserve formatting)
-        rewrite_json_version_inplace("sdks/csharp/package.json", version)?;
+        rewrite_json_version_inplace("sdks/csharp/package.json", &full_version)?;
 
         // 2) StdbModule.csproj files: SpacetimeDB.Runtime dependency -> major.minor
         let stdb_modules: &[&str] = &[
@@ -218,15 +228,23 @@ fn main() -> anyhow::Result<()> {
         rewrite_xml_tag_value(
             "crates/bindings-csharp/BSATN.Runtime/BSATN.Runtime.csproj",
             "Version",
-            version,
+            &full_version,
+        )?;
+        rewrite_xml_tag_value(
+            "crates/bindings-csharp/Runtime/Runtime.csproj",
+            "Version",
+            &full_version,
         )?;
-        rewrite_xml_tag_value("crates/bindings-csharp/Runtime/Runtime.csproj", "Version", version)?;
         rewrite_xml_tag_value(
             "crates/bindings-csharp/BSATN.Codegen/BSATN.Codegen.csproj",
             "Version",
-            version,
+            &full_version,
+        )?;
+        rewrite_xml_tag_value(
+            "crates/bindings-csharp/Codegen/Codegen.csproj",
+            "Version",
+            &full_version,
         )?;
-        rewrite_xml_tag_value("crates/bindings-csharp/Codegen/Codegen.csproj", "Version", version)?;
 
         // 4) Template StdbModule._csproj: SpacetimeDB.Runtime dependency -> major.minor.*
         rewrite_csproj_package_ref_version(