Skip to content

Commit 8967ea7

Browse files
authored
CI - Use rust-toolchain-file everywhere (#3872)
# Description of Changes We were using `rust-toolchain` in some places, and `rust-toolchain-file` in others. I think Rust released a new version, which made the `rust-toolchain` parts break with: ``` info: downloading component 'rustfmt' info: removing previous version of component 'rust-src' info: rolling back changes error: could not rename component file from '/root/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/term/terminfo/searcher' to '/root/.rustup/tmp/a4eo07uz83vsyfhk_dir/bk': Invalid cross-device link (os error 18) Error: Process completed with exit code 1. ``` (Separately, this breakage is confusing.. we'll probably run into this again when we roll forward our rust version..) # API and ABI breaking changes None. CI-only change. # Expected complexity level and risk 1 # Testing - [x] CI passes - [x] There are no more instances of `rust-toolchain`: ``` $ grep -rIP 'rust-toolchain(?!-file)' .github/workflows .github/CODEOWNERS:/rust-toolchain.toml @cloutiertyler ``` (on `master`, this finds the instances we changed) --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent 907d67e commit 8967ea7

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ jobs:
550550
cat Cargo.toml
551551
552552
- name: Install Rust toolchain
553-
uses: dtolnay/rust-toolchain@stable
553+
uses: dsherret/rust-toolchain-file@v1
554554

555555
- name: Cache Rust dependencies
556556
uses: Swatinem/rust-cache@v2
@@ -674,7 +674,7 @@ jobs:
674674
run: dotnet format --no-restore --verify-no-changes SpacetimeDB.ClientSDK.sln
675675

676676
- name: Install Rust toolchain
677-
uses: dtolnay/rust-toolchain@stable
677+
uses: dsherret/rust-toolchain-file@v1
678678

679679
- name: Cache Rust dependencies
680680
uses: Swatinem/rust-cache@v2

.github/workflows/typescript-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
# echo "Using SpacetimeDB branch from file: $branch"
8282

8383
- name: Install Rust toolchain
84-
uses: dtolnay/rust-toolchain@stable
84+
uses: dsherret/rust-toolchain-file@v1
8585

8686
- name: Cache Rust dependencies
8787
uses: Swatinem/rust-cache@v2

0 commit comments

Comments
 (0)