Skip to content

Commit 8a610dd

Browse files
committed
Rename energy_used->execution_budget_used generally
1 parent 316fd25 commit 8a610dd

12 files changed

Lines changed: 35 additions & 34 deletions

File tree

crates/client-api/src/routes/database.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ pub async fn call<S: ControlStateDelegate + NodeDelegate>(
200200
let (status, body) = reducer_outcome_response(&owner_identity, &reducer, result.outcome);
201201
Ok((
202202
status,
203-
TypedHeader(SpacetimeEnergyUsed(result.energy_used)),
203+
TypedHeader(SpacetimeEnergyUsed(result.execution_budget_used)),
204204
TypedHeader(SpacetimeExecutionDurationMicros(result.execution_duration)),
205205
body,
206206
)

crates/core/src/client/message_handlers_v1.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ impl MessageExecutionError {
139139
},
140140
status: EventStatus::FailedInternal(format!("{:#}", err)),
141141
reducer_return_value: None,
142-
execution_energy_used: FunctionBudget::ZERO,
142+
execution_budget_used: FunctionBudget::ZERO,
143143
host_execution_duration: Duration::ZERO,
144144
request_id: Some(RequestId::default()),
145145
timer: None,

crates/core/src/client/messages.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ impl ToProtocol for TransactionUpdateMessage {
440440
// elsewhere. So, we just pretend that this is `EnergyQuanta` when it's actually
441441
// a different unit, and it doesn't really matter to the client anyway.
442442
// TODO(noa): maybe we could just have this be zero, unconditionally?
443-
energy_quanta_used: EnergyQuanta::new(event.execution_energy_used.get().into()),
443+
energy_quanta_used: EnergyQuanta::new(event.execution_budget_used.get().into()),
444444
total_host_execution_duration: event.host_execution_duration.into(),
445445
caller_connection_id: event.caller_connection_id.unwrap_or(ConnectionId::ZERO),
446446
};

crates/core/src/energy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ pub trait EnergyMonitor: Send + Sync + 'static {
1717
fn record_reducer(
1818
&self,
1919
fingerprint: &FunctionFingerprint<'_>,
20-
energy_used: FunctionBudget,
20+
execution_budget_used: FunctionBudget,
2121
execution_duration: Duration,
2222
);
2323
fn record_disk_usage(&self, database: &Database, replica_id: u64, disk_usage: u64, period: Duration);
@@ -36,7 +36,7 @@ impl EnergyMonitor for NullEnergyMonitor {
3636
fn record_reducer(
3737
&self,
3838
_fingerprint: &FunctionFingerprint<'_>,
39-
_energy_used: FunctionBudget,
39+
_execution_budget_used: FunctionBudget,
4040
_execution_duration: Duration,
4141
) {
4242
}

crates/core/src/host/host_controller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ impl HostRuntimes {
148148
#[derive(Clone, Debug)]
149149
pub struct ReducerCallResult {
150150
pub outcome: ReducerOutcome,
151-
pub energy_used: FunctionBudget,
151+
pub execution_budget_used: FunctionBudget,
152152
pub execution_duration: Duration,
153153
}
154154

crates/core/src/host/instance_env.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ impl InstanceEnv {
793793
request_id: None,
794794
timer: None,
795795
// The procedure will pick up the tab for the energy.
796-
execution_energy_used: FunctionBudget::ZERO,
796+
execution_budget_used: FunctionBudget::ZERO,
797797
host_execution_duration: Duration::from_millis(0),
798798
};
799799
// Commit the tx and broadcast it.

crates/core/src/host/module_host.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ pub struct ModuleEvent {
210210
pub function_call: ModuleFunctionCall,
211211
pub status: EventStatus,
212212
pub reducer_return_value: Option<Bytes>,
213-
pub execution_energy_used: FunctionBudget,
213+
pub execution_budget_used: FunctionBudget,
214214
pub host_execution_duration: Duration,
215215
pub request_id: Option<RequestId>,
216216
pub timer: Option<Instant>,
@@ -1473,7 +1473,7 @@ impl From<EventStatus> for ViewOutcome {
14731473
pub struct ViewCallResult {
14741474
pub outcome: ViewOutcome,
14751475
pub tx: MutTxId,
1476-
pub energy_used: FunctionBudget,
1476+
pub execution_budget_used: FunctionBudget,
14771477
pub total_duration: Duration,
14781478
pub abi_duration: Duration,
14791479
}
@@ -1482,7 +1482,7 @@ impl fmt::Debug for ViewCallResult {
14821482
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
14831483
f.debug_struct("ViewCallResult")
14841484
.field("outcome", &self.outcome)
1485-
.field("energy_used", &self.energy_used)
1485+
.field("execution_budget_used", &self.execution_budget_used)
14861486
.field("total_duration", &self.total_duration)
14871487
.field("abi_duration", &self.abi_duration)
14881488
.finish()
@@ -1493,7 +1493,7 @@ impl ViewCallResult {
14931493
pub fn default(tx: MutTxId) -> Self {
14941494
Self {
14951495
outcome: ViewOutcome::Success,
1496-
energy_used: FunctionBudget::ZERO,
1496+
execution_budget_used: FunctionBudget::ZERO,
14971497
total_duration: Duration::ZERO,
14981498
abi_duration: Duration::ZERO,
14991499
tx,
@@ -2888,7 +2888,7 @@ impl ModuleHost {
28882888
// Increment execution stats
28892889
tx = result.tx;
28902890
outcome = result.outcome;
2891-
energy_used += result.energy_used;
2891+
energy_used += result.execution_budget_used;
28922892
total_duration += result.total_duration;
28932893
abi_duration += result.abi_duration;
28942894
trapped |= trap;
@@ -2902,7 +2902,7 @@ impl ModuleHost {
29022902
ViewCallResult {
29032903
outcome,
29042904
tx,
2905-
energy_used,
2905+
execution_budget_used: energy_used,
29062906
total_duration,
29072907
abi_duration,
29082908
},

crates/core/src/host/scheduler.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ fn refresh_views_then_commit_and_broadcast(
693693
status,
694694
reducer_return_value: None,
695695
//Keeping them 0 as it is internal transaction, not by reducer
696-
execution_energy_used: FunctionBudget::ZERO,
696+
execution_budget_used: FunctionBudget::ZERO,
697697
host_execution_duration: Duration::from_millis(0),
698698
request_id: None,
699699
timer: None,

crates/core/src/host/wasm_common/module_host_actor.rs

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ pub struct ExecutionStats {
238238
}
239239

240240
impl ExecutionStats {
241-
fn energy_used(&self) -> FunctionBudget {
241+
fn execution_budget_used(&self) -> FunctionBudget {
242242
self.energy.used()
243243
}
244244

@@ -661,7 +661,7 @@ impl InstanceCommon {
661661
log::info!("Database updated, {} host-type={}", stdb.database_identity(), host_type);
662662

663663
let succeed = |info: Arc<ModuleInfo>,
664-
execution_energy_used: FunctionBudget,
664+
execution_budget_used: FunctionBudget,
665665
host_execution_duration: Duration,
666666
tx: MutTxId|
667667
-> TransactionOffset {
@@ -672,7 +672,7 @@ impl InstanceCommon {
672672
function_call: ModuleFunctionCall::update(),
673673
status: EventStatus::Committed(DatabaseUpdate::default()),
674674
reducer_return_value: None,
675-
execution_energy_used,
675+
execution_budget_used,
676676
host_execution_duration,
677677
request_id: None,
678678
timer: None,
@@ -708,7 +708,8 @@ impl InstanceCommon {
708708
stdb.report_mut_tx_metrics(reducer, tx_metrics, None);
709709
UpdateDatabaseResult::ErrorExecutingMigration(anyhow::anyhow!(msg))
710710
} else {
711-
let tx_offset = succeed(self.info.clone(), out.energy_used, out.total_duration, tx);
711+
let tx_offset =
712+
succeed(self.info.clone(), out.execution_budget_used, out.total_duration, tx);
712713
UpdateDatabaseResult::UpdatePerformed {
713714
tx_offset,
714715
durable_offset,
@@ -963,7 +964,7 @@ impl InstanceCommon {
963964
};
964965

965966
// Account for view execution in reducer reporting metrics
966-
vm_metrics.report_energy_used(out.energy_used);
967+
vm_metrics.report_execution_budget_used(out.execution_budget_used);
967968
vm_metrics.report_total_duration(out.total_duration);
968969
vm_metrics.report_abi_duration(out.abi_duration);
969970

@@ -976,7 +977,7 @@ impl InstanceCommon {
976977
reducer_return_value = None;
977978
}
978979

979-
let execution_energy_used = result.stats.energy_used();
980+
let execution_budget_used = result.stats.execution_budget_used();
980981
let total_duration = result.stats.total_duration();
981982

982983
let event = ModuleEvent {
@@ -990,7 +991,7 @@ impl InstanceCommon {
990991
},
991992
status,
992993
reducer_return_value,
993-
execution_energy_used,
994+
execution_budget_used,
994995
host_execution_duration: total_duration,
995996
request_id,
996997
timer,
@@ -999,7 +1000,7 @@ impl InstanceCommon {
9991000

10001001
let res = ReducerCallResult {
10011002
outcome: ReducerOutcome::from(&event.status),
1002-
energy_used: execution_energy_used,
1003+
execution_budget_used,
10031004
execution_duration: total_duration,
10041005
};
10051006

@@ -1042,12 +1043,12 @@ impl InstanceCommon {
10421043
let result = vm_call_function(budget);
10431044

10441045
let stats: &ExecutionStats = result.as_ref();
1045-
let energy_used = stats.energy.used();
1046+
let execution_budget_used = stats.energy.used();
10461047
let timings = &stats.timings;
10471048
let memory_allocation = stats.memory_allocation;
10481049

10491050
self.energy_monitor
1050-
.record_reducer(&energy_fingerprint, energy_used, timings.total_duration);
1051+
.record_reducer(&energy_fingerprint, execution_budget_used, timings.total_duration);
10511052
if self.allocated_memory != memory_allocation {
10521053
self.metric_wasm_memory_bytes.set(memory_allocation as i64);
10531054
self.allocated_memory = memory_allocation;
@@ -1057,7 +1058,7 @@ impl InstanceCommon {
10571058

10581059
function_span
10591060
.record("timings.total_duration", tracing::field::debug(timings.total_duration))
1060-
.record("energy.used", tracing::field::debug(energy_used));
1061+
.record("energy.used", tracing::field::debug(execution_budget_used));
10611062

10621063
result
10631064
}
@@ -1313,7 +1314,7 @@ impl InstanceCommon {
13131314
let res = ViewCallResult {
13141315
outcome,
13151316
tx,
1316-
energy_used: result.stats.energy_used(),
1317+
execution_budget_used: result.stats.execution_budget_used(),
13171318
total_duration: result.stats.total_duration(),
13181319
abi_duration: result.stats.abi_duration(),
13191320
};
@@ -1365,7 +1366,7 @@ impl InstanceCommon {
13651366

13661367
out.tx = result.tx;
13671368
out.outcome = result.outcome;
1368-
out.energy_used += result.energy_used;
1369+
out.execution_budget_used += result.execution_budget_used;
13691370
out.total_duration += result.total_duration;
13701371
out.abi_duration += result.abi_duration;
13711372

@@ -1568,8 +1569,8 @@ impl VmMetrics {
15681569
self.reducer_plus_query_duration.clone().with_timer(start)
15691570
}
15701571

1571-
fn report_energy_used(&self, energy_used: FunctionBudget) {
1572-
self.reducer_fuel_used.inc_by(energy_used.get());
1572+
fn report_execution_budget_used(&self, execution_budget_used: FunctionBudget) {
1573+
self.reducer_fuel_used.inc_by(execution_budget_used.get());
15731574
}
15741575

15751576
fn report_total_duration(&self, duration: Duration) {
@@ -1582,10 +1583,10 @@ impl VmMetrics {
15821583

15831584
/// Reports some VM metrics.
15841585
fn report(&self, stats: &ExecutionStats) {
1585-
let energy_used = stats.energy.used();
1586+
let execution_budget_used = stats.energy.used();
15861587
let reducer_duration = stats.timings.total_duration;
15871588
let abi_time = stats.timings.wasm_instance_env_call_times.sum();
1588-
self.report_energy_used(energy_used);
1589+
self.report_execution_budget_used(execution_budget_used);
15891590
self.report_total_duration(reducer_duration);
15901591
self.report_abi_duration(abi_time);
15911592
}

crates/core/src/sql/execute.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ fn run_inner<I: WasmInstance>(
204204
},
205205
status: EventStatus::Committed(DatabaseUpdate::default()),
206206
reducer_return_value: None,
207-
execution_energy_used: FunctionBudget::ZERO,
207+
execution_budget_used: FunctionBudget::ZERO,
208208
host_execution_duration: Duration::ZERO,
209209
request_id: None,
210210
timer: None,

0 commit comments

Comments
 (0)