[bfops/ci-backtrace]: Merge remote-tracking branch 'origin/master' into bfops/ci-backtrace

Author: bfops

.github/workflows/ci.yml

@@ -36,7 +36,6 @@ jobs:
     timeout-minutes: 120
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
       SPACETIMEDB_CPP_DIR: ${{ github.workspace }}/crates/bindings-cpp
     steps:
       - name: Find Git ref
@@ -183,7 +182,6 @@ jobs:
 
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -274,7 +272,6 @@ jobs:
     timeout-minutes: 60
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -330,7 +327,6 @@ jobs:
     runs-on: spacetimedb-new-runner-2
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout sources
         uses: actions/checkout@v3
@@ -370,7 +366,6 @@ jobs:
     runs-on: spacetimedb-new-runner-2
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - uses: actions/checkout@v3
 
@@ -395,8 +390,6 @@ jobs:
     name: Check that packages are publishable
     runs-on: spacetimedb-new-runner-2
     permissions: read-all
-    env:
-      RUST_BACKTRACE: full
     steps:
       - uses: actions/checkout@v3
       - uses: dsherret/rust-toolchain-file@v1
@@ -416,8 +409,6 @@ jobs:
           - { target: aarch64-apple-darwin, runner: macos-latest }
           - { target: x86_64-pc-windows-msvc, runner: windows-latest }
     runs-on: ${{ matrix.runner }}
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -462,8 +453,6 @@ jobs:
       # Run as root because otherwise we get permission denied for various directories inside the container. I tried doing dances to allow it to run
       # without this (reassigning env vars and stuff), but was unable to get it to work and it felt like an uphill battle.
       options: --user 0:0
-    env:
-      RUST_BACKTRACE: full
     steps:
       # Uncomment this before merging so that it will run properly if run manually through the GH actions flow. It was playing weird with rolled back
       # commits though.
@@ -536,8 +525,6 @@ jobs:
   ci_command_docs:
     name: Check CI command docs
     runs-on: spacetimedb-new-runner-2
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -570,7 +557,6 @@ jobs:
     runs-on: spacetimedb-new-runner-2
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -641,7 +627,6 @@ jobs:
     timeout-minutes: 30
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout repository
         id: checkout-stdb
@@ -781,7 +766,6 @@ jobs:
     timeout-minutes: 30
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout repository
         id: checkout-stdb
@@ -894,145 +878,11 @@ jobs:
               exit 1
           }
 
-  internal-tests:
-    name: Internal Tests
-    needs: [lints]
-    # Skip if not a PR or a push to master
-    # Skip if this is an external contribution. GitHub secrets will be empty, so the step would fail anyway.
-    if: ${{ (github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/master'))
-      && (github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork) }}
-    permissions:
-      contents: read
-    runs-on: ubuntu-latest
-    env:
-      RUST_BACKTRACE: full
-      TARGET_OWNER: clockworklabs
-      TARGET_REPO: SpacetimeDBPrivate
-    steps:
-      - id: dispatch
-        name: Trigger tests
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.SPACETIMEDB_PRIVATE_TOKEN }}
-          script: |
-            const workflowId = 'ci.yml';
-            const targetRef = 'master';
-            const targetOwner = process.env.TARGET_OWNER;
-            const targetRepo = process.env.TARGET_REPO;
-            // Use the ref for pull requests because the head sha is brittle (github does some extra dance where it merges in master).
-            const publicRef = (context.eventName === 'pull_request') ? context.payload.pull_request.head.ref : context.sha;
-            const publicPrNumber = context.payload.pull_request?.number ?? context.payload.inputs?.pr_number;
-            const preDispatch = new Date().toISOString();
-            const inputs = { public_ref: publicRef };
-            if (publicPrNumber) {
-              inputs.public_pr_number = String(publicPrNumber);
-            }
-
-            // Dispatch the workflow in the target repository
-            await github.rest.actions.createWorkflowDispatch({
-              owner: targetOwner,
-              repo: targetRepo,
-              workflow_id: workflowId,
-              ref: targetRef,
-              inputs,
-            });
-  
-            const sleep = (ms) => new Promise(r => setTimeout(r, ms));
-  
-            // Find the dispatched run by name
-            let runId = null;
-            for (let attempt = 0; attempt < 20 && !runId; attempt++) { // up to ~10 minutes to locate the run
-              await sleep(5000);
-              const runsResp = await github.rest.actions.listWorkflowRuns({
-                owner: targetOwner,
-                repo: targetRepo,
-                workflow_id: workflowId,
-                event: 'workflow_dispatch',
-                branch: targetRef,
-                per_page: 50,
-              });
-  
-              const expectedName = `CI [public_ref=${publicRef}]`;
-              const candidates = runsResp.data.workflow_runs
-                .filter(r => r.name === expectedName && new Date(r.created_at) >= new Date(preDispatch))
-                .sort((a, b) => new Date(b.created_at) - new Date(a.created_at));
-  
-              if (candidates.length > 0) {
-                runId = candidates[0].id;
-                break;
-              }
-            }
-  
-            if (!runId) {
-              core.setFailed('Failed to locate dispatched run in the private repository.');
-              return;
-            }
-  
-            const runUrl = `https://github.com/${targetOwner}/${targetRepo}/actions/runs/${runId}`;
-            core.info(`View run: ${runUrl}`);
-            core.setOutput('run_id', String(runId));
-            core.setOutput('run_url', runUrl);
-  
-      - name: Wait for Internal Tests to complete
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.SPACETIMEDB_PRIVATE_TOKEN }}
-          script: |
-            const targetOwner = process.env.TARGET_OWNER;
-            const targetRepo = process.env.TARGET_REPO;
-            const runId = Number(`${{ steps.dispatch.outputs.run_id }}`);
-            const runUrl = `${{ steps.dispatch.outputs.run_url }}`;
-            const sleep = (ms) => new Promise(r => setTimeout(r, ms));
-  
-            core.info(`Waiting for workflow result... ${runUrl}`);
-  
-            let conclusion = null;
-            for (let attempt = 0; attempt < 240; attempt++) { // up to ~2 hours
-              const runResp = await github.rest.actions.getWorkflowRun({
-                owner: targetOwner,
-                repo: targetRepo,
-                run_id: runId
-              });
-              const { status, conclusion: c } = runResp.data;
-              if (status === 'completed') {
-                conclusion = c || 'success';
-                break;
-              }
-              await sleep(30000);
-            }
-  
-            if (!conclusion) {
-              core.setFailed('Timed out waiting for private workflow to complete.');
-              return;
-            }
-  
-            if (conclusion !== 'success') {
-              core.setFailed(`Private workflow failed with conclusion: ${conclusion}`);
-            }
-  
-      - name: Cancel invoked run if workflow cancelled
-        if: ${{ cancelled() }}
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.SPACETIMEDB_PRIVATE_TOKEN }}
-          script: |
-            const targetOwner = process.env.TARGET_OWNER;
-            const targetRepo = process.env.TARGET_REPO;
-            const runId = Number(`${{ steps.dispatch.outputs.run_id }}`);
-            if (!runId) return;
-            await github.rest.actions.cancelWorkflowRun({
-              owner: targetOwner,
-              repo: targetRepo,
-              run_id: runId,
-            });
-
   global_json_policy:
     name: Verify global.json files are symlinks
     runs-on: ubuntu-latest
     permissions:
       contents: read
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -1072,7 +922,6 @@ jobs:
       contents: read
     env:
       CARGO_TARGET_DIR: ${{ github.workspace }}/target
-      RUST_BACKTRACE: full
     steps:
       - name: Find Git ref
         env:
@@ -1125,8 +974,6 @@ jobs:
   docs-build:
     name: Docs build
     runs-on: spacetimedb-new-runner-2
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -1164,8 +1011,6 @@ jobs:
   typescript-test:
     name: TypeScript - Tests
     runs-on: spacetimedb-new-runner-2
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -1276,8 +1121,6 @@ jobs:
 
   version_upgrade_check:
     runs-on: spacetimedb-new-runner-2
-    env:
-      RUST_BACKTRACE: full
     steps:
       - name: Checkout
         uses: actions/checkout@v3