Skip to content

Commit aff07a0

Browse files
jdetterbfops
andauthored
Move typescript tests to new runner (#3696)
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> - This just moves the typescript tests onto the custom runner. |Test|Before|After|% Change| |---|---|---|---| |Typescript - Lint|1m|<1m|No change| |Typescript - Build + Test|14m|5m|64%| # API and ABI breaking changes None <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> # Expected complexity level and risk 1 - if the typescript tests become flaky this could be the reason. <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> # Testing - [x] The typescript CI still passes and is faster. <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent 6689848 commit aff07a0

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

.github/workflows/typescript-lint.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ on:
99

1010
jobs:
1111
build:
12-
runs-on: ubuntu-latest
12+
runs-on: spacetimedb-new-runner
13+
container:
14+
image: localhost:5000/spacetimedb-ci:latest
15+
options: --privileged
16+
1317

1418
steps:
1519
- name: Checkout repository

.github/workflows/typescript-test.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ concurrency:
1313

1414
jobs:
1515
build-and-test:
16-
runs-on: ubuntu-latest
16+
runs-on: spacetimedb-new-runner
17+
container:
18+
image: localhost:5000/spacetimedb-ci:latest
19+
options: --privileged
1720
env:
1821
CARGO_TARGET_DIR: ${{ github.workspace }}/target
1922

@@ -93,8 +96,8 @@ jobs:
9396
cargo install --force --path crates/cli --locked --message-format=short
9497
cargo install --force --path crates/standalone --locked --message-format=short
9598
# Add a handy alias using the old binary name, so that we don't have to rewrite all scripts (incl. in submodules).
96-
rm -f $HOME/.cargo/bin/spacetime
97-
ln -s $HOME/.cargo/bin/spacetimedb-cli $HOME/.cargo/bin/spacetime
99+
rm -f $CARGO_HOME/bin/spacetime
100+
ln -s $CARGO_HOME/bin/spacetimedb-cli $CARGO_HOME/bin/spacetime
98101
# Clear any existing information
99102
spacetime server clear -y
100103

0 commit comments

Comments
 (0)