Skip to content

Commit bc12806

Browse files
Apply suggestions from code review
Co-authored-by: Mario Montoya <mamcx@elmalabarista.com> Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
1 parent e44323e commit bc12806

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

crates/core/src/subscription/module_subscription_manager.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,11 +1118,11 @@ impl SubscriptionManager {
11181118
&row.elements[edge.lhs_join_col.idx()],
11191119
)
11201120
// This read should always succeed, and it's a bug if it doesn't.
1121-
.unwrap()
1121+
.expect("This read should always succeed, and it's a bug if it doesn't")
11221122
.next()
11231123
.map(|row| {
11241124
// Similarly this read should always succeed
1125-
row.read_col(edge.rhs_col).unwrap()
1125+
row.read_col(edge.rhs_col).expect("This read should always succeed, and it's a bug if it doesn't")
11261126
})
11271127
}
11281128

crates/subscription/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ impl std::fmt::Display for TableName {
300300
pub struct JoinEdge {
301301
/// The [`TableId`] for `a`
302302
pub lhs_table: TableId,
303-
/// The [`TableId`] for `a`
303+
/// The [`TableId`] for `b`
304304
pub rhs_table: TableId,
305305
/// The [`ColId`] for `a.id`
306306
pub lhs_join_col: ColId,

0 commit comments

Comments
 (0)