Skip to content

Commit c38b135

Browse files
authored
CI - No cache-on-failure (#3903)
# Description of Changes Disable `cache-on-failure` as we think that it's contributing to mysterious `rusty_v8` linker issues. I bumped the prefix key so that PRs with this change don't share caches with PRs missing this change. # API and ABI breaking changes CI only. # Expected complexity level and risk 1 # Testing None. We'll have to see if we stop having issues once this is merged. --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent a914094 commit c38b135

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ jobs:
6060
with:
6161
workspaces: ${{ github.workspace }}
6262
shared-key: spacetimedb
63-
cache-on-failure: true
63+
cache-on-failure: false
6464
cache-all-crates: true
6565
cache-workspace-crates: true
66+
prefix-key: v1
6667

6768
- uses: actions/setup-dotnet@v4
6869
with:
@@ -153,6 +154,7 @@ jobs:
153154
shared-key: spacetimedb
154155
# Let the smoketests job save the cache since it builds the most things
155156
save-if: false
157+
prefix-key: v1
156158

157159
- uses: actions/setup-dotnet@v3
158160
with:
@@ -197,6 +199,7 @@ jobs:
197199
shared-key: spacetimedb
198200
# Let the smoketests job save the cache since it builds the most things
199201
save-if: false
202+
prefix-key: v1
200203

201204
- uses: actions/setup-dotnet@v3
202205
with:
@@ -227,6 +230,7 @@ jobs:
227230
shared-key: spacetimedb
228231
# Let the smoketests job save the cache since it builds the most things
229232
save-if: false
233+
prefix-key: v1
230234

231235
- name: Run bindgen tests
232236
run: cargo ci wasm-bindings
@@ -490,6 +494,7 @@ jobs:
490494
shared-key: spacetimedb
491495
# Let the smoketests job save the cache since it builds the most things
492496
save-if: false
497+
prefix-key: v1
493498

494499
- name: Check for docs change
495500
run: |
@@ -554,6 +559,7 @@ jobs:
554559
shared-key: spacetimedb
555560
# Let the main CI job save the cache since it builds the most things
556561
save-if: false
562+
prefix-key: v1
557563

558564
- name: Install SpacetimeDB CLI from the local checkout
559565
run: |
@@ -678,6 +684,7 @@ jobs:
678684
shared-key: spacetimedb
679685
# Let the main CI job save the cache since it builds the most things
680686
save-if: false
687+
prefix-key: v1
681688

682689
- name: Install SpacetimeDB CLI from the local checkout
683690
run: |

.github/workflows/typescript-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ jobs:
9090
shared-key: spacetimedb
9191
# Let the main CI job save the cache since it builds the most things
9292
save-if: false
93+
prefix-key: v1
9394

9495
- name: Install SpacetimeDB CLI from the local checkout
9596
run: |

0 commit comments

Comments
 (0)