Revert "Add smoketest artifact build command"

This reverts commit 2aa5b8c.

Author: clockworklabs

tools/ci/src/smoketest.rs

@@ -3,7 +3,7 @@ use anyhow::{bail, ensure, Result};
 use clap::{Args, Subcommand};
 use duct::cmd;
 use std::ffi::OsStr;
-use std::path::{Path, PathBuf};
+use std::path::Path;
 use std::process::{Command, Stdio};
 use std::{env, fs};
 
@@ -36,9 +36,6 @@ pub struct SmoketestsArgs {
 
 #[derive(Subcommand)]
 enum SmoketestCmd {
-    /// Build smoketest artifacts without running tests
-    BuildArtifacts,
-
     /// Only build binaries without running tests
     ///
     /// Use this before running `cargo test --all` to ensure binaries are built.
@@ -48,13 +45,8 @@ enum SmoketestCmd {
 
 pub fn run(args: SmoketestsArgs) -> Result<()> {
     match args.cmd {
-        Some(SmoketestCmd::BuildArtifacts) => {
-            build_artifacts()?;
-            eprintln!("Smoketest artifacts ready.");
-            Ok(())
-        }
         Some(SmoketestCmd::Prepare) => {
-            build_artifacts()?;
+            build_binaries()?;
             eprintln!("Binaries ready. You can now run `cargo test --all`.");
             Ok(())
         }
@@ -67,12 +59,6 @@ pub fn run(args: SmoketestsArgs) -> Result<()> {
     }
 }
 
-fn build_artifacts() -> Result<()> {
-    build_binaries()?;
-    build_precompiled_modules()?;
-    Ok(())
-}
-
 fn build_binaries() -> Result<()> {
     eprintln!("Building spacetimedb-cli and spacetimedb-standalone (release)...");
 
@@ -111,9 +97,6 @@ fn build_binaries() -> Result<()> {
 fn build_precompiled_modules() -> Result<()> {
     let workspace_root = env::current_dir()?;
     let modules_dir = workspace_root.join("crates/smoketests/modules");
-    let target_dir = env::var_os("SPACETIME_SMOKETEST_MODULE_TARGET_DIR")
-        .map(PathBuf::from)
-        .unwrap_or_else(|| modules_dir.join("target"));
 
     // Check if the modules workspace exists
     if !modules_dir.join("Cargo.toml").exists() {
@@ -132,7 +115,6 @@ fn build_precompiled_modules() -> Result<()> {
             "wasm32-unknown-unknown",
         ])
         .current_dir(&modules_dir)
-        .env("CARGO_TARGET_DIR", &target_dir)
         .status()?;
 
     ensure!(status.success(), "Failed to build pre-compiled modules");
@@ -145,8 +127,11 @@ fn build_precompiled_modules() -> Result<()> {
 const DEFAULT_PARALLELISM: &str = "16";
 
 fn run_smoketest(server: Option<String>, dotnet: bool, args: Vec<String>) -> Result<()> {
-    // 1. Build artifacts first (single process, no race)
-    build_artifacts()?;
+    // 1. Build binaries first (single process, no race)
+    build_binaries()?;
+
+    // 2. Build pre-compiled modules (this also warms the WASM dependency cache)
+    build_precompiled_modules()?;
 
     // 4. Detect whether to use nextest or cargo test
     let use_nextest = Command::new("cargo")