Merge remote-tracking branch 'origin/master' into bot/docs-audit

Author: rain

crates/client-api/src/routes/subscribe.rs

@@ -669,6 +669,10 @@ async fn ws_main_loop<HotswapWatcher>(
             // Exit if we haven't heard from the client for too long.
             _ = &mut idle_timer => {
                 log::warn!("Client {} timed out", state.client_id);
+                WORKER_METRICS
+                    .ws_clients_idle_timed_out
+                    .with_label_values(&state.database)
+                    .inc();
                 break;
             },
 

crates/core/src/worker_metrics/mod.rs

@@ -36,6 +36,11 @@ metrics_group!(
         #[labels(database_identity: Identity)]
         pub ws_clients_closed_connection: IntGaugeVec,
 
+        #[name = spacetime_worker_ws_clients_idle_timed_out_total]
+        #[help = "The cumulative number of ws client connections disconnected after becoming idle"]
+        #[labels(database_identity: Identity)]
+        pub ws_clients_idle_timed_out: IntCounterVec,
+
         #[name = spacetime_websocket_requests_total]
         #[help = "The cumulative number of websocket request messages"]
         #[labels(database_identity: Identity, protocol: str)]