Skip to content

Commit dd8c89b

Browse files
committed
v8: improve some TODOs
1 parent 6a92b92 commit dd8c89b

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

crates/core/src/host/v8/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ impl fmt::Display for JsStackTraceFrame {
206206

207207
// This isn't exactly the same format as chrome uses,
208208
// but it's close enough for now.
209-
// TODO(centril): make it more like chrome in the future.
209+
// TODO(v8): make it more like chrome in the future.
210210
f.write_fmt(format_args!(
211211
"at {} ({}:{}:{})",
212212
fn_name, script_name, &self.line, &self.column

crates/core/src/host/v8/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ impl ModuleInstance for JsInstance {
156156
params,
157157
log_traceback,
158158
|tx, op, budget| {
159-
// TODO(centril): snapshots, module->host calls
159+
// TODO(v8): snapshots, module->host calls
160160
// Setup V8 scope.
161161
let mut isolate: v8::OwnedIsolate = Isolate::new(<_>::default());
162162
let isolate_handle = isolate.thread_safe_handle();
@@ -179,7 +179,7 @@ impl ModuleInstance for JsInstance {
179179
let energy = EnergyStats { budget, remaining };
180180
let timings = ExecutionTimings {
181181
total_duration,
182-
// TODO(centril): call times.
182+
// TODO(v8): call times.
183183
wasm_instance_env_call_times: CallTimes::new(),
184184
};
185185

@@ -206,7 +206,7 @@ fn run_reducer_timeout(isolate_handle: IsolateHandle, budget: ReducerBudget) ->
206206
let execution_done_flag2 = execution_done_flag.clone();
207207
let timeout = budget_to_duration(budget);
208208

209-
// TODO(centril): Using an OS thread is a bit heavy handed...?
209+
// TODO(v8): Using an OS thread is a bit heavy handed...?
210210
thread::spawn(move || {
211211
// Sleep until the timeout.
212212
thread::sleep(timeout);
@@ -225,13 +225,13 @@ fn run_reducer_timeout(isolate_handle: IsolateHandle, budget: ReducerBudget) ->
225225
}
226226

227227
fn budget_to_duration(_budget: ReducerBudget) -> Duration {
228-
// TODO(centril): This is fake logic that allows a maximum timeout.
228+
// TODO(v8): This is fake logic that allows a maximum timeout.
229229
// Replace with sensible math.
230230
Duration::MAX
231231
}
232232

233233
fn duration_to_budget(_duration: Duration) -> ReducerBudget {
234-
// TODO(centril): This is fake logic that allows minimum energy usage.
234+
// TODO(v8): This is fake logic that allows minimum energy usage.
235235
// Replace with sensible math.
236236
ReducerBudget::ZERO
237237
}

crates/core/src/host/v8/ser.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ impl<'this, 'scope> ser::Serializer for Serializer<'this, 'scope> {
150150
}
151151

152152
fn serialize_named_product(self, _len: usize) -> Result<Self::SerializeNamedProduct, Self::Error> {
153-
// TODO(noa): this can be more efficient if we tell it the names ahead of time
153+
// TODO(v8, noa): this can be more efficient if we tell it the names ahead of time
154154
let object = Object::new(self.scope);
155155
Ok(SerializeNamedProduct {
156156
inner: self,

0 commit comments

Comments
 (0)