CI - Clean up several scripts and call sites related to codegen (#3363)

# Description of Changes

* Small cleanups in `tools/check-diff.sh`
* Use `tools/check-diff.sh` wherever appropriate
* Simplify the `sdks/csharp/tools~/gen-*.sh` files after the repo merge

# API and ABI breaking changes

None.

# Expected complexity level and risk

1

# Testing

- [x] CI still passes

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>

Author: bfops

examples~/quickstart-chat/client/README.md

@@ -3,8 +3,8 @@ See [SpacetimeDB](https://github.com/clockworklabs/SpacetimeDB)/modules/quicksta
 
 ## Regenerating bindings
 
-To regenerate bindings: clone SpacetimeDB next to this repo, then in the root of this repo:
+To regenerate bindings: clone SpacetimeDB next to this repo, then in `sdks/csharp` of this repo:
 
 ```bash
-tools~/gen-quickstart.sh ../SpacetimeDB
-```
+tools~/gen-quickstart.sh
+```

tools~/gen-client-api.sh

@@ -2,9 +2,9 @@
 
 set -ueo pipefail
 
-STDB_PATH="$1"
 SDK_PATH="$(dirname "$0")/.."
 SDK_PATH="$(realpath "$SDK_PATH")"
+STDB_PATH="$SDK_PATH/../.."
 
 cargo build --manifest-path "$STDB_PATH/crates/standalone/Cargo.toml"
 

tools~/gen-quickstart.sh

@@ -2,9 +2,9 @@
 
 set -ueo pipefail
 
-STDB_PATH="$1"
 SDK_PATH="$(dirname "$0")/.."
 SDK_PATH="$(realpath "$SDK_PATH")"
+STDB_PATH="$SDK_PATH/../.."
 
 cargo build --manifest-path "$STDB_PATH/crates/standalone/Cargo.toml"
 cargo run --manifest-path "$STDB_PATH/crates/cli/Cargo.toml" -- generate -y -l csharp -o "$SDK_PATH/examples~/quickstart-chat/client/module_bindings" --project-path "$SDK_PATH/examples~/quickstart-chat/server"

tools~/gen-regression-tests.sh

@@ -2,9 +2,9 @@
 
 set -ueo pipefail
 
-STDB_PATH="$1"
 SDK_PATH="$(dirname "$0")/.."
 SDK_PATH="$(realpath "$SDK_PATH")"
+STDB_PATH="$SDK_PATH/../.."
 
 cargo build --manifest-path "$STDB_PATH/crates/standalone/Cargo.toml"
 cargo run --manifest-path "$STDB_PATH/crates/cli/Cargo.toml" -- generate -y -l csharp -o "$SDK_PATH/examples~/regression-tests/client/module_bindings" --project-path "$SDK_PATH/examples~/regression-tests/server"

tools~/run-regression-tests.sh

@@ -4,12 +4,12 @@
 
 set -ueo pipefail
 
-STDB_PATH="$1"
 SDK_PATH="$(dirname "$0")/.."
 SDK_PATH="$(realpath "$SDK_PATH")"
+STDB_PATH="$SDK_PATH/../.."
 
 # Regenerate Bindings
-"$SDK_PATH/tools~/gen-regression-tests.sh" "$STDB_PATH"
+"$SDK_PATH/tools~/gen-regression-tests.sh"
 
 # Build and run SpacetimeDB server
 cargo build --manifest-path "$STDB_PATH/crates/standalone/Cargo.toml"
@@ -27,4 +27,4 @@ cargo run --manifest-path "$STDB_PATH/crates/cli/Cargo.toml" call republish-test
 cd "$SDK_PATH/examples~/regression-tests/client" && dotnet run -c Debug
 
 # Run client for republishing module test
-cd "$SDK_PATH/examples~/regression-tests/republishing/client" && dotnet run -c Debug
+cd "$SDK_PATH/examples~/regression-tests/republishing/client" && dotnet run -c Debug

tools~/update-against-stdb.sh

@@ -9,9 +9,9 @@ SDK_PATH="$(dirname "$0")/.."
 SDK_PATH="$(realpath "$SDK_PATH")"
 
 "$SDK_PATH/tools~/write-nuget-config.sh" "$STDB_PATH"
-"$SDK_PATH/tools~/gen-client-api.sh" "$STDB_PATH"
-"$SDK_PATH/tools~/gen-quickstart.sh" "$STDB_PATH"
-"$SDK_PATH/tools~/gen-regression-tests.sh" "$STDB_PATH"
+"$SDK_PATH/tools~/gen-client-api.sh"
+"$SDK_PATH/tools~/gen-quickstart.sh"
+"$SDK_PATH/tools~/gen-regression-tests.sh"
 dotnet nuget locals all --clear
 dotnet pack "$STDB_PATH/crates/bindings-csharp"
 rm -rf "$SDK_PATH/packages"