Skip to content

Commit e9ecfa9

Browse files
bradleyshepclockwork-labs-bot
andauthored
Keynote fixes/refinements (#4418)
# Description of Changes Integrate the `keynote-2` benchmark template into the pnpm workspace so it uses the local SpacetimeDB TypeScript SDK instead of a pinned npm version. - Add `templates/keynote-2` to `pnpm-workspace.yaml` and switch its `spacetimedb` dependency to `workspace:*` - Regenerate module bindings for SDK 2.0.1 - Update `DEVELOP.md`: bump Node.js prerequisite to ≥ 22.x (required by the SDK's use of `Promise.withResolvers`), update CLI commands to use `cargo run -p spacetimedb-cli --` for local development - Fix `build` script: use `tsc` only (keynote-2 is a Node.js CLI app, not a web app — `vite build` fails without an `index.html`) - Fix demo results display: treat 0 TPS as a failure (`✗ FAILED`) instead of showing it as a valid result and producing a nonsensical "Infinityx FASTER" comparison - Enable `LOG_ERRORS` by default in the demo so reducer failures are immediately visible instead of silently producing 0 TPS - Minor cleanup: fix unused variable warning in `init_sqlite_seed_in_docker.ts` # API and ABI breaking changes None. # Expected complexity level and risk 1 — Scoped entirely to the `keynote-2` template and its workspace integration. No changes to the SDK, server, or any other template. # Testing - [ ] Run `pnpm install && pnpm --filter spacetimedb build` from repo root - [ ] Run `pnpm run demo -- --systems spacetimedb --seconds 3` from `templates/keynote-2` against a local SpacetimeDB server and confirm non-zero TPS - [ ] Verify that a system producing 0 TPS shows `✗ FAILED` and is excluded from the comparison chart - [ ] Verify that reducer errors are printed to console during benchmark failures --------- Co-authored-by: clockwork-labs-bot <bot@clockworklabs.com>
1 parent 2b85157 commit e9ecfa9

7 files changed

Lines changed: 514 additions & 57 deletions

File tree

0 commit comments

Comments
 (0)