File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -9,7 +9,6 @@ use crate::host::wasm_common::module_host_actor::{
99} ;
1010use crate :: host:: ArgsTuple ;
1111use crate :: { host:: Scheduler , module_host_context:: ModuleCreationContext , replica_context:: ReplicaContext } ;
12- use anyhow:: anyhow;
1312use core:: sync:: atomic:: { AtomicBool , Ordering } ;
1413use core:: time:: Duration ;
1514use de:: deserialize_js;
@@ -87,6 +86,10 @@ impl V8RuntimeInner {
8786 return Err :: < JsModule , _ > ( anyhow ! ( "v8_todo" ) ) ;
8887 }
8988
89+ // TODO(v8): determine min required ABI by module and check that it's supported?
90+
91+ // TODO(v8): validate function signatures like in WASM? Is that possible with V8?
92+
9093 let desc = todo ! ( ) ;
9194 // Validate and create a common module rom the raw definition.
9295 let common = build_common_module_from_raw ( mcc, desc) ?;
@@ -124,6 +127,17 @@ impl Module for JsModule {
124127 }
125128
126129 fn create_instance ( & self ) -> Self :: Instance {
130+ // TODO(v8): consider some equivalent to `epoch_deadline_callback`
131+ // where we report `Js has been running for ...`.
132+
133+ // TODO(v8): timeout things like `extract_description`.
134+
135+ // TODO(v8): do we care about preinits / setup or are they unnecessary?
136+
137+ // TODO(v8): create `InstanceEnv`.
138+
139+ // TODO(v8): extract description.
140+
127141 todo ! ( )
128142 }
129143}
You can’t perform that action at this time.
0 commit comments