memory_order_relaxed

Author: joshua-spacetime

crates/core/src/client/client_connection.rs

@@ -160,9 +160,7 @@ impl ClientConnectionSender {
     }
 
     pub fn is_cancelled(&self) -> bool {
-        // We check this when processing subscription updates to exit early for dropped clients.
-        // We use `Acquire` here because we prioritize early exit over cheaper loads.
-        self.cancelled.load(Ordering::Acquire)
+        self.cancelled.load(Ordering::Relaxed)
     }
 
     /// Send a message to the client. For data-related messages, you should probably use
@@ -182,9 +180,7 @@ impl ClientConnectionSender {
                 // the channel, so forcibly kick the client
                 tracing::warn!(identity = %self.id.identity, connection_id = %self.id.connection_id, "client channel capacity exceeded");
                 self.abort_handle.abort();
-                // We check this when processing subscription updates to exit early for dropped clients.
-                // We use `Release` here because we prioritize early exit over cheaper stores.
-                self.cancelled.store(true, Ordering::Release);
+                self.cancelled.store(true, Ordering::Relaxed);
                 return Err(ClientSendError::Cancelled);
             }
             Err(mpsc::error::TrySendError::Closed(_)) => return Err(ClientSendError::Disconnected),

crates/core/src/subscription/module_subscription_manager.rs

@@ -1278,9 +1278,7 @@ struct SendWorkerClient {
 
 impl SendWorkerClient {
     fn is_dropped(&self) -> bool {
-        // We check this when processing subscription updates to exit early for dropped clients.
-        // We use `Acquire` here because we prioritize early exit over cheaper loads.
-        self.dropped.load(Ordering::Acquire)
+        self.dropped.load(Ordering::Relaxed)
     }
 
     fn is_cancelled(&self) -> bool {